Skip to content

[psud] Bug fix: the fields that are not supported by vendor should be "N/A" in STATE_DB#168

Merged
jleveque merged 1 commit intosonic-net:masterfrom
stephenxs:fix-not-supported-field-2
Mar 30, 2021
Merged

[psud] Bug fix: the fields that are not supported by vendor should be "N/A" in STATE_DB#168
jleveque merged 1 commit intosonic-net:masterfrom
stephenxs:fix-not-supported-field-2

Conversation

@stephenxs
Copy link
Copy Markdown
Collaborator

Description

Bug fix: the fields that are not supported by the vendor should be "N/A" in STATE_DB

  • Initialize fields as "N/A" and set the field to "N/A" for those not supported by vendor API
  • Update set_voltage, set_temperature, treating "N/A" instead of None as invalid values
  • Update unit test cases accordingly

Signed-off-by: Stephen Sun [email protected]

Motivation and Context

How Has This Been Tested?

Manually test and regression test

Additional Information (Optional)

…in STATE_DB

- Initialize fields as "N/A" and set the field to "N/A" for those not supported by vendor API
- Update set_voltage, set_temperature, treating "N/A" instead of None as invalid values
- Update unit test cases accordingly

Signed-off-by: Stephen Sun <[email protected]>
@jleveque jleveque merged commit 450b7d7 into sonic-net:master Mar 30, 2021
@liat-grozovik
Copy link
Copy Markdown
Collaborator

@stephenxs can you please update submodule? if this is also relevant to 202012 please specify.

@stephenxs stephenxs deleted the fix-not-supported-field-2 branch March 30, 2021 20:49
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants