Fix GCU update speed case to use supported speed get from the dut#5843
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jun 24, 2022
Merged
Fix GCU update speed case to use supported speed get from the dut#5843liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
The replace speed test case uses hard coded speed parameters, the params may not be supported by some DUTs(e.g. 20G speed is not supported by all nvidia platforms) So fix the case to get supported speeds from dut, and test with 2 random supported speed. For vs setups without actual port speed, still use the origin hard coded speed.
5 tasks
nhe-NV
approved these changes
Jun 21, 2022
liat-grozovik
approved these changes
Jun 24, 2022
Collaborator
|
@congh-nvidia reelvant for 202012 branch? |
Contributor
Author
No, 202012 doesn't support this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The test_update_speed case now uses hard coded speed parameters, the speed params may not be supported by some DUTs(e.g. 20G speed is not supported by all nvidia platforms), need to be fixed.
This PR combines multiple commits in #5766 (Closed)
Type of change
Back port request
Approach
What is the motivation for this PR?
The test_update_speed case now uses hard coded speed parameters, the speed params may not be supported by some DUTs(e.g. 20G speed is not supported by all nvidia platforms). In order to run this case on all testbeds, need to use supported speeds got from the dut instead of the hardcoded speeds.
How did you do it?
Add a function to get the supported speeds from the dut, and use them in the test case.
The fix uses 2 valid speeds(randomly selected from all supported speeds) and 1 invalid speed(the value is not changed) just as it was before.
For vs setups, because there is no actual supported speed to get, still use the original hard coded valid speed params(20000, 40000).
How did you verify/test it?
Have run this case on 2 different testbeds with nvidia switches, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation