Skip to content

Avoid long run test in GCU.#5816

Merged
wen587 merged 2 commits intosonic-net:masterfrom
wen587:avoid_long_run
Jun 20, 2022
Merged

Avoid long run test in GCU.#5816
wen587 merged 2 commits intosonic-net:masterfrom
wen587:avoid_long_run

Conversation

@wen587
Copy link
Contributor

@wen587 wen587 commented Jun 15, 2022

Description of PR

Summary: Skip long running test in GCU. Will improve later.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

Need to reduce test time by request.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 marked this pull request as ready for review June 16, 2022 03:57
@wen587 wen587 requested a review from a team as a code owner June 16, 2022 03:57
@wen587 wen587 requested a review from qiluo-msft June 16, 2022 04:38

@pytest.fixture(autouse=True, scope="module")
def avoid_long_running_test():
pytest.skip("Test costs too much time. Temp skip for now.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official document gives a short solution with allow_module_level
https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another way to add marker for skip.

@wen587 wen587 merged commit 1307ca3 into sonic-net:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants