Fix test case: generic_config_updater/test_eth_interface.py::test_replace_mtu#5692
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom May 25, 2022
Merged
Conversation
…lace_mtu The case uses Ethernet0 to do the replacing mtu test, but in our community setups, Ethernet0 is a member of a port channel. The mtu of port channel member should not be modified directly. Add logic to select a ethernet port not in a port channel for the test.
nhe-NV
approved these changes
May 23, 2022
Collaborator
|
@yxieca could you please help to review or assing someone to do so? |
yutongzhang-microsoft
approved these changes
May 25, 2022
This was referenced Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The test_replace_mtu case uses Ethernet0 to do the replacing mtu test. But in some testbeds, Ethernet0 is a member of a port channel. The mtu of port channel member should not be modified directly.
Type of change
Back port request
Approach
What is the motivation for this PR?
The test_replace_mtu case uses Ethernet0 to do the replacing mtu test. But in some testbeds, Ethernet0 is a member of a port channel. The mtu of port channel member should not be modified directly(can't config mtu of a port channel member via CLI).
Take a t1-64-lag testbed for example:
How did you do it?
How did you verify/test it?
Have run this case on t0-64 and t-64-lag testbeds, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation