Fix test case: generic_config_updater/test_ipv6.py::test_ipv6_neighbor_admin_change#5647
Merged
liat-grozovik merged 3 commits intosonic-net:masterfrom May 19, 2022
Merged
Conversation
…r_admin_change This case fails every time on our community setup because it tries to replace the value of config entry " BGP_NEIGHBOR/fc00::12/admin_status", while this entry doesn't exist in the default running configuratuion.(The admin_status is up by default, but it doesn't show in the configuration.) To fix this, need to add this config before replace it. And add a topology mark for the test according to the description in sonic-net#5061 .
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
isabelmsft
approved these changes
May 18, 2022
Contributor
Author
|
/azp run Azure.sonic-mgmt |
|
Commenter does not have sufficient privileges for PR 5647 in repo Azure/sonic-mgmt |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
To fix this, need to add this config before replace it.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Run this test case on testbeds with and without the admin_status field in running configs, all passed.
Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation