[GCU] Add ethernet interface tests#5257
Merged
isabelmsft merged 4 commits intosonic-net:masterfrom Mar 17, 2022
Merged
Conversation
wen587
reviewed
Mar 1, 2022
qiluo-msft
reviewed
Mar 4, 2022
qiluo-msft
reviewed
Mar 4, 2022
qiluo-msft
reviewed
Mar 16, 2022
qiluo-msft
reviewed
Mar 16, 2022
| for line in status_data: | ||
| if "Ethernet0" in line: | ||
| ethernet0_status = line.strip() | ||
| status = re.split(r" {2,}", ethernet0_status)[field_index] |
Contributor
Contributor
Author
There was a problem hiding this comment.
"Type" property has value with more than one word (eg "QSFP+ or later with SFP-8636 or SFF-8436"), but the different properties are always separated by 2+ spaces. So regex split based on 2+ spaces in between characters
qiluo-msft
approved these changes
Mar 17, 2022
Contributor
Author
|
For replace lanes test, opened new issue sonic-net/sonic-utilities#2263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add ethernet interface config updater tests
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
Update relevant ethernet interface configs
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
t0, t1
Documentation