[tests/generic_config_updater] Replace IP testcase for BGP Listener#5092
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom Feb 10, 2022
Merged
[tests/generic_config_updater] Replace IP testcase for BGP Listener#5092qiluo-msft merged 3 commits intosonic-net:masterfrom
qiluo-msft merged 3 commits intosonic-net:masterfrom
Conversation
wen587
changed the title
|
This pull request introduces 2 alerts when merging 137fd15 into 180d891 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 8d610ba into 180d891 - view on LGTM.com new alerts:
|
qiluo-msft
reviewed
Feb 9, 2022
tests/common/helpers/generators.py
Outdated
|
|
||
|
|
||
| def generate_ip_through_default_route(host): | ||
| def generate_ip_through_default_route(host, exclude_ips=[]): |
Contributor
There was a problem hiding this comment.
Do not use mutable as default parameter, the behavior is not as expected.
ref: https://codeql.github.com/codeql-query-help/python/py-modification-of-default-value/
Actually LGTM alert is a true issue. #Closed
qiluo-msft
reviewed
Feb 9, 2022
qiluo-msft
reviewed
Feb 9, 2022
qiluo-msft
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Replace IP testcase for BGP Listener
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Add the testcase.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_bgpl.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation