Skip to content

[201911] Verify buffer priority groups for all platforms#4491

Merged
neethajohn merged 4 commits intosonic-net:201911from
stephenxs:reclaim-buffer-201911-all-platform
Nov 1, 2021
Merged

[201911] Verify buffer priority groups for all platforms#4491
neethajohn merged 4 commits intosonic-net:201911from
stephenxs:reclaim-buffer-201911-all-platform

Conversation

@stephenxs
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Verify buffer priority groups for non-Mellanox platforms as well.

Signed-off-by: Stephen Sun [email protected]

How did you do it?

To verify:

  • On Mellanox platform, the lossless buffer profile is applied on PG 3-4 only if the port is admin down
  • On non-Mellanox platforms, the lossless buffer profile is applied on PG 3-4 of all interfaces regardless of their admin status.

How did you verify/test it?

It was verified on Mellanox platform. An old image without reclaiming buffer is adapted to simulate non-Mellanox platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@stephenxs stephenxs requested a review from a team as a code owner October 14, 2021 16:12
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 1 alert when merging 047e2bc into 0639353 - view on LGTM.com

new alerts:

  • 1 for Use of 'global' at module level

@stephenxs
Copy link
Contributor Author

/azpw run

Signed-off-by: Stephen Sun <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2021

This pull request fixes 1 alert when merging 2a9a33e into 0639353 - view on LGTM.com

fixed alerts:

  • 1 for Use of 'global' at module level

Signed-off-by: Stephen Sun <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2021

This pull request fixes 1 alert when merging a610788 into 0639353 - view on LGTM.com

fixed alerts:

  • 1 for Use of 'global' at module level

@yxieca
Copy link
Collaborator

yxieca commented Oct 25, 2021

@stephenxs are you able to make master branch test case also cover 201911 branch?

@neethajohn
Copy link
Contributor

@stephenxs are you able to make master branch test case also cover 201911 branch?

Yes. master branch can cover 201911

@liat-grozovik
Copy link
Collaborator

@yxieca and @neethajohn can you approve and sign off?

@neethajohn neethajohn merged commit bdb27e7 into sonic-net:201911 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants