Skip to content

[Buffer manager][201911]Regression test case for traditional buffer manager in 201911#3889

Merged
qiluo-msft merged 7 commits intosonic-net:201911from
stephenxs:201911-buffer-manager-github
Sep 27, 2021
Merged

[Buffer manager][201911]Regression test case for traditional buffer manager in 201911#3889
qiluo-msft merged 7 commits intosonic-net:201911from
stephenxs:201911-buffer-manager-github

Conversation

@stephenxs
Copy link
Contributor

Description of PR

Summary:
Add test case for traditional buffer manager for fundamental functionalities and reclaiming unused buffer.

Signed-off-by: Stephen Sun stephens@nvidia.com

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Add test case for traditional buffer manager for fundamental functionalities and reclaiming unused buffer.

How did you do it?

  1. For all ports in the config_db,
    • Check whether there is no lossless buffer PG configured on an admin-down port
    • Check whether the lossless PG aligns with the port's speed and cable length
    • If the name-to-OID maps exist for port and PG, check whether the information in ASIC_DB aligns with that in CONFIG_DB
    • If a lossless profile hasn't been checked, check whether the lossless profile in CONFIG_DB aligns with
      • pg_profile_lookup.ini according to speed and cable length
      • information in ASIC_DB
  2. Shutdown a port and check whether the lossless buffer PG has been removed
  3. Startup the port and check whether the lossless PG has been readded.

How did you verify/test it?

Run regression test.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

1. For all ports in the config_db,
   - Check whether there is no lossless buffer PG configured on an admin-down port
   - Check whether the lossless PG aligns with the port's speed and cable length
   - If name to oid maps exist for port and PG, check whether the information in ASIC_DB aligns with that in CONFIG_DB
   - If a lossless profile hasn't been checked, check whether lossless profile in CONFIG_DB aligns with
     - pg_profile_lookup.ini according to speed and cable length
     - information in ASIC_DB
2. Shutdown a port and check whether the lossless buffer PG has been remvoed
3. Startup the port and check whether the lossless PG has been readded.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs requested a review from neethajohn July 26, 2021 13:45
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review September 13, 2021 07:23
@stephenxs stephenxs requested a review from a team as a code owner September 13, 2021 07:23
@neethajohn
Copy link
Contributor

@stephenxs , isn't this testcases only applicable to 201911? Then we also need to add a version check in the beginning and skip if there is a version mismatch

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
- Check whether file exists before cat it
- Skip the test if the version is not 201911

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Contributor Author

@stephenxs , isn't this testcases only applicable to 201911? Then we also need to add a version check in the beginning and skip if there is a version mismatch

Fixed.

@qiluo-msft qiluo-msft merged commit 0639353 into sonic-net:201911 Sep 27, 2021
@stephenxs stephenxs deleted the 201911-buffer-manager-github branch September 27, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants