[platform]Optimize reboot-cause testcase#1167
Merged
lguohan merged 2 commits intosonic-net:masterfrom Oct 18, 2019
stephenxs:optimize-reboot-cause
Merged
[platform]Optimize reboot-cause testcase#1167lguohan merged 2 commits intosonic-net:masterfrom stephenxs:optimize-reboot-cause
lguohan merged 2 commits intosonic-net:masterfrom
stephenxs:optimize-reboot-cause
Conversation
…dog reboot. The power off and watchdog reboot share the same working flow with cold reboot except that their reboot causes differ and the motivation of them is to verify whether the reboot cause is correct. In this sense, it is unnecessary to do the full check for them.
Rewording.
lguohan
approved these changes
Oct 17, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Optimize reboot-cause testcase via checking reboot-cause only for power off and watchdog reboot.
The power off and watchdog reboot share the same working flow with cold reboot except that their reboot causes differ and the motivation of them is to verify whether the reboot cause is correct.
In this sense, it is unnecessary to do the full check for them. By doing so we can reduce a lot of minutes.
Type of change
Approach
How did you do it?
Skip checkings other than reboot-cause for power off and watchdog reboot.
How did you verify/test it?
Run platform test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation