SONiC Management Framework Release 1.0#18
Merged
renukamanavalan merged 886 commits intosonic-net:masterfrom Dec 23, 2019
Merged
SONiC Management Framework Release 1.0#18renukamanavalan merged 886 commits intosonic-net:masterfrom
renukamanavalan merged 886 commits intosonic-net:masterfrom
Conversation
Change-Id: I5917eb03c44410fcf0aa0ceb5720cd5c12415d00
fix path in on-change subscribe code
fix path in on-change subscribe code
…ling in common app.
Change-Id: I82ec0a1610da009f9906d0ac2ab7c5eb5aa4b13b
…mmented lines in xmfr_acl
* Fix for not showing description when description is configured as part of #show interface command. * Addressing the crash when max mtu is set as 9276. Currently supported max-mtu is 9216. * Fix for bugs 96, 97 and 107 * Addressed the comment to sort the speed * Change MAX_MTU to 9216 in platform_dummy file as well, since it overwrites it.
…value from sonic-cli" into broadcom_sonic
…T_RULE." into broadcom_sonic
merge mgmt-framework bug fixes from Dell - 12th Sept
Change-Id: I2a92251040a816c24f8433e49dd508091dbb494b
Change-Id: Iec675bff98c912ef5d80a2d38524748d6a0b1683
… address." into broadcom_sonic
…terface Change-Id: Ic3e89d74bd399e891a06e14bd4ff7dcd486a9090
Addressing review comments in PR #18
renukamanavalan
left a comment
renukamanavalan
left a comment
There was a problem hiding this comment.
In general, please add resolve to all open comments.
| } | ||
|
|
||
| leaf alias { | ||
| type string; |
Release 1.0 port
Address PR review comments - phase2
|
Please add a build-check as basic validation, before we push this. |
Contributor
Checked the build. docker-sonic-mgmt-framework.gz build is successful on release_1.0 branch. |
|
Thanks for the confirmation. My request was "to add that as part of checks for this PR". For example, in case of swss submodule, any PR had to build a the swss submodule (sample here). Can we add such a test to this submodule ? |
* Add validation for speed and description * Add pattern for alias
seiferteric
reviewed
Dec 3, 2019
Rebase from Release 1.0
testcases as per latest YANG model.
Patch file changes and updating test case based on YANG model update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONiC Management Framework Release 1.0