[system-health] No longer check critical process/service status via monit#9068
Merged
qiluo-msft merged 9 commits intosonic-net:masterfrom Nov 23, 2021
Merged
Conversation
Junchao-Mellanox
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
This was referenced Oct 26, 2021
keboliu
previously approved these changes
Oct 26, 2021
|
This pull request introduces 1 alert when merging 5a8d671 into b0c73d9 - view on LGTM.com new alerts:
|
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
qiluo-msft
reviewed
Oct 26, 2021
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
32fbcdf to
a218d1b
Compare
Collaborator
|
Add a link of your design doc to the PR description. |
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
84fbf7b to
f8982b6
Compare
Collaborator
Author
|
Hi @qiluo-msft , I have fixed all review comment, could you please review and sign-off? |
Collaborator
Author
|
Hi @qiluo-msft , could you please review and sign off? |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
06c8b23 to
042fd95
Compare
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Could you rebase to latest master? |
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
042fd95 to
e799843
Compare
Collaborator
Author
|
No clean cherry-pick for 202106/202012, need separate PRs. |
qiluo-msft
approved these changes
Nov 23, 2021
This was referenced Nov 24, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 24, 2021
…tus via monit (#9367) Backport #9068 to 202012 #### Why I did it Command `monit summary -B` can no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to address that. monit is still used by system-health to do file system check as well as customize check. #### How I did it 1. Get container names from FEATURE table 2. For each container, collect critical process names from file critical_processes 3. Use “docker exec -it <container_name> bash -c ‘supervisorctl status’” to get processes status inside container, parse the output and check if any critical processes exit #### How to verify it 1. Add unit test case to cover it 2. Adjust sonic-mgmt cases to cover it 3. Manual test
Contributor
Can you submit separate PRs against 202012/202106 please? |
Collaborator
Author
|
Hi @yozhao101, I suppose they are already in 202012 and 202106. Please check #9366 and #9367 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD updated here: sonic-net/SONiC#887
Why I did it
Command
monit summary -Bcan no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to address that. monit is still used by system-health to do file system check as well as customize check.How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)