Add trap flow counter support#8940
Merged
prsunny merged 1 commit intosonic-net:masterfrom Nov 24, 2021
Merged
Conversation
Collaborator
Author
|
Hi @lguohan, could you please suggest a reviewer? |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Collaborator
Author
|
/AzurePipelines run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 8940 in repo Azure/sonic-buildimage |
keboliu
previously approved these changes
Nov 17, 2021
prsunny
previously approved these changes
Nov 23, 2021
Contributor
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
Lgtm, can yang subgroup review the Yang file change?
Junchao-Mellanox
dismissed stale reviews from prsunny and keboliu
via
801d8a0
Junchao-Mellanox
force-pushed
the
flow-counter
branch
from
9268fa3 to
801d8a0
Compare
prsunny
approved these changes
Nov 24, 2021
Junchao-Mellanox
added
the
Request for 202111 Branch
abdosi
removed
the
Request for 202111 Branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add trap flow counter support
How I did it
Enable trap flow rate calculation
How to verify it
Manual test/VS test/sonic-mgmt test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)