[docker-base]: Rate limit priority INFO and lower in syslog#5666
Merged
theasianpianist merged 2 commits intosonic-net:masterfrom Oct 20, 2020
Merged
[docker-base]: Rate limit priority INFO and lower in syslog#5666theasianpianist merged 2 commits intosonic-net:masterfrom
theasianpianist merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <[email protected]>
jleveque
suggested changes
Oct 19, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Can you also please update the related comments to read:
# Set a rate limit on messages from the container of INFO level (level 6) or lower
Contributor
|
You may also want to make the same change here: files/image_config/rsyslog/rsyslog-container.conf.j2 |
* Update comments to reflect new behavior * Also change files/image_config/rsyslog/rsyslog-container.conf.j2 Signed-off-by: Lawrence Lee <[email protected]>
jleveque
approved these changes
Oct 19, 2020
lguohan
approved these changes
Oct 20, 2020
3 tasks
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#5666) There is currently a bug where messages from swss with priority lower than the current log level are still being counted against the syslog rate limiting threshhold. This leads to rate-limiting in syslog when the rate-limiting conditions have not been met, which causes several sonic-mgmt tests to fail since they are dependent on LogAnalyzer. It also omits potentially useful information from the syslog. Only rate-limiting messages of level INFO and lower allows these tests to pass successfully. Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee [email protected]
Temporary fix for #5570
- Why I did it
There is currently a bug where messages from swss with priority lower than the current log level are still being counted against the syslog rate limiting threshhold. This leads to rate-limiting in syslog when the rate-limiting conditions have not been met, which causes several sonic-mgmt tests to fail since they are dependent on LogAnalyzer. It also omits potentially useful information from the syslog. Only rate-limiting messages of level INFO and lower allows these tests to pass successfully.
- How I did it
Add
$SystemLogRateLimitSeverityoption torsyslog.confin the base Dockerfiles- How to verify it
Build a new orchagent image and install it. Run the ACL tests, which should now pass. No rate limiting should occur in the syslogs.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)