Skip to content

incomplete bgp route map for RM_SET_SRC/RM_SET_SRC6#3765

Closed
tylerlinp wants to merge 14 commits intosonic-net:masterfrom
tylerlinp:loopback
Closed

incomplete bgp route map for RM_SET_SRC/RM_SET_SRC6#3765
tylerlinp wants to merge 14 commits intosonic-net:masterfrom
tylerlinp:loopback

Conversation

@tylerlinp
Copy link
Contributor

@tylerlinp tylerlinp commented Nov 15, 2019

- What I did
Fix the issue #3735

  1. fix the "Loopback0": {}, by modifying minigraph.py(Prince has made the fix in sonic-utilities for db migrate (Adding LOOPBACK interface to db migrate script sonic-utilities#734))
  2. Generate the ip address configuration for setting src to solve configuration recovering failed.

- How I did it

- How to verify it
test

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 18, 2019

Build triggered for merge commit.

@tylerlinp
Copy link
Contributor Author

retest vs please

1 similar comment
@akokhan
Copy link
Contributor

akokhan commented Nov 19, 2019

retest vs please

ip address {{ lo_ipv4_addrs[0] }}
{% endif %}
{% if lo_ipv6_addrs|length > 0 %}
ipv6 address {{ lo_ipv6_addrs[0] | ip }}/{{ lo_ipv6_addrs[0] | prefixlen }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not subscript the config db lo address change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so does all configs in templates, there are several commands referenced the lo address. To follow changes, a lot of work to do. I think it is a new requirement.

@tylerlinp
Copy link
Contributor Author

retest vs please

@prsunny
Copy link
Contributor

prsunny commented Nov 21, 2019

hi Tyler, can you please separate the minigraph changes to another PR as we would need that to unblock load minigraph.

@tylerlinp
Copy link
Contributor Author

@prsunny OK. PR #3792

@pavel-shirshov pavel-shirshov self-requested a review November 21, 2019 23:27
@pavel-shirshov pavel-shirshov self-assigned this Nov 21, 2019
@lguohan
Copy link
Collaborator

lguohan commented May 21, 2020

obsoleted by 057ced0

@lguohan lguohan closed this May 21, 2020
mssonicbld added a commit that referenced this pull request Jul 23, 2025
…lly (#23348)

#### Why I did it
src/sonic-swss
```
* 9dbd983b - (HEAD -> 202505, origin/202505) Merge pull request #3762 from mssonicbld/cherry/202505/3712 (18 hours ago) [Jianquan Ye]
|\ 
| failure_prs.log skip_prs.log b950d0a6 - [vs][mirror]: Update test to use the max TC number provided by VS lib (9 days ago) [Sonic Build Admin]
* 75cba2df - [trim]: Add Packet Trimming Asym DSCP to OA (#3765) (7 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants