Skip to content

[Mellanox] platform_reboot - sync & umount fs before power cycle (#3430)#3476

Merged
sujinmkang merged 1 commit intosonic-net:201811from
mykolaf:platf_reboot_201811
Sep 26, 2019
Merged

[Mellanox] platform_reboot - sync & umount fs before power cycle (#3430)#3476
sujinmkang merged 1 commit intosonic-net:201811from
mykolaf:platf_reboot_201811

Conversation

@mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Sep 18, 2019

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

We noticed that null characters sometimes appear in our logs after we started using power cycle to reboot.

NOTICE admin: User requested rebooting device ...
> ^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@

This gets in the way of greping the logs.

- What I did
Made sure the filesystem is synced and unmounted before performing the power cycle.
- How I did it

- How to verify it
Perform multiple reboots, then
cat -A /var/log/syslog* | grep -A 15 rebooting | grep ^@
Check that no null characters are present
- Description for the changelog

Made sure the filesystem is synced and unmounted before performing the power cycle on Mellanox platforms.

- A picture of a cute animal (not mandatory but encouraged)

@sujinmkang sujinmkang merged commit e572080 into sonic-net:201811 Sep 26, 2019
@mykolaf mykolaf deleted the platf_reboot_201811 branch February 18, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants