Skip to content

[Centec] Replace swsssdk with swsscommon in centec devices.#11350

Merged
liuh-80 merged 1 commit intosonic-net:masterfrom
liuh-80:dev/liuh/replace-swsssdk-centec
Aug 24, 2022
Merged

[Centec] Replace swsssdk with swsscommon in centec devices.#11350
liuh-80 merged 1 commit intosonic-net:masterfrom
liuh-80:dev/liuh/replace-swsssdk-centec

Conversation

@liuh-80
Copy link
Copy Markdown
Contributor

@liuh-80 liuh-80 commented Jul 6, 2022

Why I did it

Update scripts in sonic-buildimage from py-swsssdk to swsscommon

How I did it

Replace swsssdk with swsscommon in centec devices.

How to verify it

Pass all E2E test case

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Replace swsssdk with swsscommon in centec devices.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 requested a review from qiluo-msft July 6, 2022 02:10
@liuh-80 liuh-80 requested review from a team and lguohan as code owners July 6, 2022 02:10
@liuh-80 liuh-80 mentioned this pull request Jul 6, 2022
Merged
7 tasks
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 6, 2022

This pull request fixes 2 alerts when merging fc734f2cc36ea610d4569c714affe65db5033b08 into 7b98cf3 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 6, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 6, 2022

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 6, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 6, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 6, 2022

Some UT failed, seems not related with PR code change, because same change passed all UT in another PR before.

@qiluo-msft
Copy link
Copy Markdown
Collaborator

qiluo-msft commented Jul 6, 2022

@yangbashuang Could you help review?

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 7, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 7, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 11, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 11, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Jul 12, 2022

@yangbashuang , could you help review and give your comments?

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Aug 10, 2022

/easycla

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Aug 10, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: liuh-80 / name: Hua Liu (1581831)

@liuh-80
Copy link
Copy Markdown
Contributor Author

liuh-80 commented Aug 10, 2022

/easycla

@liuh-80 liuh-80 force-pushed the dev/liuh/replace-swsssdk-centec branch from fc734f2 to 1581831 Compare August 10, 2022 02:45
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 10, 2022

This pull request fixes 2 alerts when merging 1581831 into 2af7498 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@liuh-80 liuh-80 merged commit 776c93b into sonic-net:master Aug 24, 2022
@liuh-80 liuh-80 deleted the dev/liuh/replace-swsssdk-centec branch August 24, 2022 04:39
@guxianghong
Copy link
Copy Markdown
Contributor

guxianghong commented Aug 26, 2022

@yangbashuang , could you help review and give your comments?

@yangbashuang isn't working on centec sonic project now. @liuh-80 you may call @guxianghong or @LuiSzee whenever you need. Thanks.

@qiluo-msft
Copy link
Copy Markdown
Collaborator

qiluo-msft commented Aug 26, 2022

@guxianghong @LuiSzee Please help verify this PR even it is merged.

@LuiSzee
Copy link
Copy Markdown
Contributor

LuiSzee commented Aug 27, 2022

@guxianghong @LuiSzee Please help verify this PR even it is merged.

I have verified that it works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liuh-80 @qiluo-msft @guxianghong @LuiSzee