[Accton] Remove unused swsssdk import from accton device code#11348
Merged
liuh-80 merged 1 commit intosonic-net:masterfrom Aug 24, 2022
Merged
[Accton] Remove unused swsssdk import from accton device code#11348liuh-80 merged 1 commit intosonic-net:masterfrom
liuh-80 merged 1 commit intosonic-net:masterfrom
Conversation
7 tasks
|
This pull request fixes 1 alert when merging cd47b9b0c652815dac7147bce88e3ba49b78b42e into 7b98cf3 - view on LGTM.com fixed alerts:
|
Collaborator
|
@jostar-yang Could you help review? |
Contributor
Author
|
@jostar-yang, could you help review and give your comments? |
Contributor
Author
|
/easycla |
|
|
liuh-80
force-pushed
the
dev/liuh/replace-swsssdk-accton
branch
from
cd47b9b to
2fad284
Compare
|
This pull request fixes 1 alert when merging 2fad284 into 2af7498 - view on LGTM.com fixed alerts:
|
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Update scripts in sonic-buildimage from py-swsssdk to swsscommon
How I did it
Remove unused swsssdk import from accton device code
How to verify it
Pass all E2E test case
Which release branch to backport (provide reason below if selected)
Description for the changelog
Remove unused swsssdk import from accton device code
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)