Skip to content

[Nokia ixs7215] Platform API temperature threshold value fixes#10372

Merged
Blueve merged 1 commit intosonic-net:masterfrom
dflynn-Nokia:temp-threshold-fixes
Apr 7, 2022
Merged

[Nokia ixs7215] Platform API temperature threshold value fixes#10372
Blueve merged 1 commit intosonic-net:masterfrom
dflynn-Nokia:temp-threshold-fixes

Conversation

@dflynn-Nokia
Copy link
Contributor

Incorrect high-threshold and critical-high-threshold values are displayed for
some of the temperature sensors. This commit fixes that.

Why I did it

Incorrect high-threshold and critical-high-threshold values are displayed for
some of the temperature sensors

How I did it

Modify the thermal sensor Platform API 2.0 implementation to return the correct values.

How to verify it

Ensure that the 'show platform temperature' command show the correct high-threshold and critical-high-threshold values for each thermal sensor.

Values displayed before the fix.

admin@localhost:~$ show platform temperature
     Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
-----------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
ADT7473-CPU         23          191.0       N/A           100.0            N/A      False  20220328 16:08:56
ADT7473-LOC         23.5        191.0       N/A           100.0            N/A      False  20220328 16:08:56
ADT7473-MAC         22.5        191.0       N/A           100.0            N/A      False  20220328 16:08:56
   CPU Core         21.5          N/A       N/A             N/A            N/A      False  20220328 16:08:56
    PCB MAC         27.375       80.0       N/A             N/A            N/A      False  20220328 16:08:56
    PCB PHY         21.5         80.0       N/A             N/A            N/A      False  20220328 16:08:56

Values displayed after the fix

admin@challenger:~$ show platform temperature 
     Sensor    Temperature    High TH    Low TH    Crit High TH    Crit Low TH    Warning          Timestamp
-----------  -------------  ---------  --------  --------------  -------------  ---------  -----------------
ADT7473-CPU         24          100.0       N/A             N/A            N/A      False  20220328 15:49:09
ADT7473-LOC         25          100.0       N/A             N/A            N/A      False  20220328 15:49:09
ADT7473-MAC         23.5        100.0       N/A             N/A            N/A      False  20220328 15:49:09
   CPU Core         22.625        N/A       N/A             N/A            N/A      False  20220328 15:49:09
    PCB MAC         28.75        80.0       N/A             N/A            N/A      False  20220328 15:49:09
    PCB PHY         22.625       80.0       N/A             N/A            N/A      False  20220328 15:49:09

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Incorrect high-threshold and critical-high-threshold values are displayed for
some of the temperature sensors. This commit fixes that.
@dflynn-Nokia dflynn-Nokia requested a review from lguohan as a code owner March 28, 2022 16:17
@dflynn-Nokia
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor

Blueve commented Apr 7, 2022

Do we have any test in sonic-mgmt can catch this issue?

@Blueve Blueve merged commit e348dff into sonic-net:master Apr 7, 2022
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants