Skip to content

Commit a2c3acf

Browse files
authored
[action] [PR:22067] [Mellanox] Update SN56xx relevant SKUs buffers_defaults_objects.j2 (#990)
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it To have buffers updated to new requirements to following SKUs: Mellanox-SN5600-C256S1 Mellanox-SN5600-C224O8 Mellanox-SN5610N-C256S2 Mellanox-SN5610N-C224O8 Mellanox-SN5640-C512S2 Mellanox-SN5600-C448O16 sonic-mgmt test update: sonic-net/sonic-mgmt#17788 ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Set port.alpha to 1/64. Set queue.alpha for queues 1, 2, and 3 to 1. Set queue.alpha for queue 4 to infinity or 128 #### How to verify it Load an image with the change on Mellanox system, check SDK dumps and run sonic-mgmt test. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
1 parent d7eecd3 commit a2c3acf

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

device/mellanox/x86_64-nvidia_sn5600-r0/Mellanox-SN5600-C256S1/buffers_defaults_objects.j2

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"ingress_lossy_profile": {
7272
"pool":"ingress_lossless_pool",
7373
"size":"0",
74-
"dynamic_th":"3"
74+
"dynamic_th":"7"
7575
},
7676
"egress_lossless_profile": {
7777
"pool":"egress_lossless_pool",
@@ -81,22 +81,22 @@
8181
"egress_lossy_profile": {
8282
"pool":"egress_lossy_pool",
8383
"size":"9216",
84-
"dynamic_th":"7"
84+
"dynamic_th":"-6"
8585
},
8686
"q_lossy_profile": {
8787
"pool":"egress_lossy_pool",
8888
"size":"0",
8989
"dynamic_th":"0"
9090
},
91-
"q_lossy_minus_7_profile": {
91+
"q_lossy_minus_3_profile": {
9292
"pool": "egress_lossy_pool",
9393
"size": "0",
94-
"dynamic_th" : "-7"
94+
"dynamic_th" : "-3"
9595
},
96-
"q_lossy_minus_3_profile": {
96+
"q_lossy_infinity_profile": {
9797
"pool": "egress_lossy_pool",
9898
"size": "0",
99-
"dynamic_th" : "-3"
99+
"dynamic_th" : "7"
100100
}
101101
},
102102
{%- endmacro %}
@@ -149,18 +149,13 @@
149149
{%- macro generate_queue_buffers(port_names_active, port_names_inactive) %}
150150
"BUFFER_QUEUE": {
151151
{% for port in port_names_active.split(',') %}
152-
"{{ port }}|0": {
152+
"{{ port }}|0-3": {
153153
"profile" : "q_lossy_profile"
154154
},
155155
{% endfor %}
156-
{% for port in port_names_active.split(',') %}
157-
"{{ port }}|1-3": {
158-
"profile" : "q_lossy_minus_7_profile"
159-
},
160-
{% endfor %}
161156
{% for port in port_names_active.split(',') %}
162157
"{{ port }}|4": {
163-
"profile" : "q_lossy_profile"
158+
"profile" : "q_lossy_infinity_profile"
164159
},
165160
{% endfor %}
166161
{% for port in port_names_active.split(',') %}

device/mellanox/x86_64-nvidia_sn5600-r0/Mellanox-SN5600-C256S1/qos.json.j2

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,4 +167,13 @@
167167
},
168168
{%- endmacro %}
169169

170+
{%- macro generate_lossless_tc_list(lossless_tc_list) %}
171+
{#
172+
This macro intentionally does nothing, leaving LOSSLESS_TC as an empty list
173+
Use the following to generate other lists like 3, 4
174+
{%- if lossless_tc_list.append('3') -%}{%- endif -%}
175+
{%- if lossless_tc_list.append('4') -%}{%- endif -%}
176+
#}
177+
{%- endmacro %}
178+
170179
{%- include 'qos_config.j2' %}

0 commit comments

Comments
 (0)