Skip to content

Conversation

@JiaqiZhang-Dev
Copy link
Member

@JiaqiZhang-Dev JiaqiZhang-Dev commented Jul 4, 2025

  1. fix: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5048545&view=logs&j=83516c17-6666-5250-abde-63983ce72a49&t=00be4b52-4a63-5865-8e02-c61723ad0692
  2. comment unused test, since it'll cause github api throttle
    image
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@JiaqiZhang-Dev JiaqiZhang-Dev marked this pull request as ready for review July 4, 2025 09:04
Copilot AI review requested due to automatic review settings July 4, 2025 09:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the internal generator dependency and removes an unused test to avoid GitHub API throttling.

  • Bumps eng/tools/generator/internal to a new commit.
  • Comments out the TestParseReadmeFromLink test in request_test.go to prevent API rate limits.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/tools/generator/go.mod Updated internal module dependency version.
eng/tools/generator/cmd/issue/request/request_test.go Commented out test code to remove GitHub API calls.
Comments suppressed due to low confidence (1)

eng/tools/generator/cmd/issue/request/request_test.go:6

  • Removing this test eliminates coverage for ParseReadmeFromLink; consider using a mocked GitHub client to retain coverage without triggering API rate limits.
// func TestParseReadmeFromLink(t *testing.T) {

@JiaqiZhang-Dev JiaqiZhang-Dev enabled auto-merge (squash) July 4, 2025 09:26
@JiaqiZhang-Dev JiaqiZhang-Dev merged commit f8192a1 into main Jul 4, 2025
23 checks passed
@JiaqiZhang-Dev JiaqiZhang-Dev deleted the upgrade_internal branch July 4, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants