Skip to content

Allow an additional retry for IMDS managed identity requests #24860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Allow an additional retry for IMDS managed identity requests #24860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da11390
Allow an additional retry for IMDS managed identity requests
chlowell Jun 26, 2025
c222186
restore default TryTimeout
chlowell Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/azidentity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
### Bugs Fixed

### Other Changes
- By default, `ManagedIdentityCredential` retries IMDS requests for a maximum of ~70 seconds as recommended
in IMDS documentation. In previous versions, it would stop retrying after ~54 seconds by default.

## 1.10.1 (2025-06-10)

Expand Down
7 changes: 2 additions & 5 deletions sdk/azidentity/managed_identity_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ type managedIdentityClient struct {
// setIMDSRetryOptionDefaults sets zero-valued fields to default values appropriate for IMDS
func setIMDSRetryOptionDefaults(o *policy.RetryOptions) {
if o.MaxRetries == 0 {
o.MaxRetries = 5
o.MaxRetries = 6
}
if o.MaxRetryDelay == 0 {
o.MaxRetryDelay = 1 * time.Minute
o.MaxRetryDelay = 25 * time.Second
}
if o.RetryDelay == 0 {
o.RetryDelay = 2 * time.Second
Expand All @@ -82,9 +82,6 @@ func setIMDSRetryOptionDefaults(o *policy.RetryOptions) {
http.StatusNetworkAuthenticationRequired, // 511
}
}
if o.TryTimeout == 0 {
o.TryTimeout = 1 * time.Minute
}
}

// newManagedIdentityClient creates a new instance of the ManagedIdentityClient with the ManagedIdentityCredentialOptions
Expand Down