Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Fix arrangement of arguments. #339

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix arrangement of arguments. #339

merged 1 commit into from
Jun 10, 2025

Conversation

@conniey
Copy link
Member

@conniey conniey commented Jun 10, 2025 •
edited
Loading

What does this PR do?

Fixes instruction for using env file in docker.

GitHub issue number?

Fixes #308

Checklist before merging

  • I have read the contribution guidelines on pull request process, code style, and testing.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • If it's a core feature, I have added thorough tests.
  • If it's a noteworthy bug fix or new feature, I have added an entry in CHANGELOG.md with a link back to the PR or issue
  • Have a team member run live tests:
    • Team Member: Inspect PR for security issues before queueing a test run
    • Team Member: Add this comment to the pr /azp run azure - mcp to start the run

@conniey conniey requested a review from a team as a code owner June 10, 2025 21:03
@conniey conniey requested review from hallipr, jongio and joshfree June 10, 2025 21:03
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server (OLD) Jun 10, 2025
@joshfree
Copy link
Member

joshfree commented Jun 10, 2025

Should this live in a sample or someplace other than only the readme.md too?

@conniey
Copy link
Member Author

conniey commented Jun 10, 2025

Should this live in a sample or someplace other than only the readme.md too?

No. This is what users have to copy and paste into their mcp.json to get it to work, similar to the manual install instructions for using npx.

@conniey conniey merged commit 440130e into Azure:main Jun 10, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server (OLD) Jun 10, 2025
@conniey conniey deleted the readme-update branch June 10, 2025 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner automatically assigned from Azure/azure-mcp

@jongio jongio Awaiting requested review from jongio jongio is a code owner automatically assigned from Azure/azure-mcp

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-mcp

@wbreza wbreza Awaiting requested review from wbreza wbreza is a code owner automatically assigned from Azure/azure-mcp

@JonathanCrd JonathanCrd Awaiting requested review from JonathanCrd JonathanCrd is a code owner automatically assigned from Azure/azure-mcp

2 more reviewers

@joshfree joshfree joshfree approved these changes

@xiangyan99 xiangyan99 xiangyan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Azure MCP Server (OLD)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker image doesn't recognise the --env-file argument

3 participants

@conniey @joshfree @xiangyan99