This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Add Azure SQL Advise Command #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongio
requested review from
conniey,
g2vinay,
hallipr,
joshfree,
rohit-ganguly,
wbreza and
xiangyan99
xiangyan99
reviewed
Jun 9, 2025
xiangyan99
reviewed
Jun 9, 2025
Member
|
Please also update docs/azmcp-commands.md. |
wbreza
approved these changes
Jun 10, 2025
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Looks good overall - just a few low priority comments. Main comment is around whether or not we need to re-expose types for the command results vs leveraging existing objects from the SDKs. Are we trimming down the amount of data or other reasons?
xiangyan99
approved these changes
Jun 11, 2025
anuchandy
approved these changes
Jun 12, 2025
| { | ||
| DatabaseNotFoundException => "Database not found. Verify the database exists and you have access.", | ||
| _ => base.GetErrorMessage(ex) | ||
| }; internal record DbAdviseCommandResult(SqlAnalysisResult Analysis) : IDbAdviseCommandResult |
Member
There was a problem hiding this comment.
nit; should this record definition be in a new line?
src/Services/Azure/Sql/SqlService.cs
Outdated
| var patterns = new[] | ||
| { | ||
| @"ON\s+\[?([^\]\s\[]+)\]?\.\[?([^\]\s\[]+)\]?", // ON [schema].[table] or ON schema.table | ||
| @"ON\s+\[?([^\]\s\[]+)\]?(?!\s*\.)", // ON [table] (without schema) |
Member
There was a problem hiding this comment.
In Java, we try to compile the regex upfront so it can help with perf.
Reading the doc, .NET seems to have similar concept https://learn.microsoft.com/en-us/dotnet/standard/base-types/regular-expression-source-generators#compiled-regular-expressions, so we could avoid runtime regx compilation (and is AOT friendly).
// / ON [schema].[table] or ON schema.table
[GeneratedRegex(@"ON\s+\[?([^\]\s\[]+)\]?\.\[?([^\]\s\[]+)\]?", RegexOptions.IgnoreCase)]
private static partial Regex NameFromTableSchemaRegex();
// // ON [table] (without schema)
[GeneratedRegex(@"ON\s+\[?([^\]\s\[]+)\]?(?!\s*\.)", RegexOptions.IgnoreCase)]
private static partial Regex NameFromTableOnlyRegex();var match = NameFromTableSchemaRegex().Match(sql);
// rest is the same code.
Member
Author
|
We are waiting for a db to be available that has auto tuning recommendations so we can test this. It takes 7 days for a db to show auto-tuning recommendations, so we'll verify it next week. |
…ex recommendations - Introduced new SQL command groups for managing Azure SQL resources. - Added commands for listing SQL servers and databases. - Implemented index recommendation functionality with appropriate options. - Created base command classes for SQL operations to streamline command creation. - Enhanced error handling for SQL operations with custom exceptions. - Updated documentation to reflect new command structure and usage. - Added unit tests for SQL index recommendation command to ensure functionality.
…g; deprecate old model
…thods and improve error handling
…g across SQL command files
…oup parameter and updating related methods
… handling in SqlService; add unit tests for SQL service functionality
…g SQL servers and databases; add SqlAuthorizationException for error handling
…Command and BaseServerCommand; update index recommendation logic and options handling
…ance index recommendation command with tenant support
…structure and additional metadata; update related commands and tests
- Removed the SqlIndexRecommendCommand and its associated tests. - Introduced DbAdviseCommand to provide SQL database advisor recommendations. - Updated CommandFactory to register new Db commands and removed obsolete index commands. - Created BaseDbCommand for shared functionality among database commands. - Implemented DbListCommand for listing SQL databases. - Added ServerListCommand for listing SQL servers. - Updated SqlService to support advisor type filtering in GetIndexRecommendationsAsync. - Refactored SQL option definitions to include advisor type options. - Created new tests for DbAdviseCommand to ensure correct functionality and error handling. - Removed outdated SqlIndexRecommendCommandTests.
…and tests with improved analysis result handling
…ndation handling; replace index analysis with general recommendations
…emove deprecated SqlIndexRecommendation model and update related tests
…AdviseCommand, DatabaseAdviseOptions, SqlService, ISqlService, and DbAdviseCommandTests
…null handling and code simplification
… simplifying method definitions
…descriptions and parameter naming
…ge assertions and validation checks
Co-authored-by: Xiang Yan <[email protected]>
…azmcp-commands.md
…null check in OnCallTools
…arser utility class with tests
jongio
commented
Jun 18, 2025
Member
Author
jongio
left a comment
jongio
left a comment
There was a problem hiding this comment.
I'm still working on getting an env that has db recommendations so I can test this.
Member
Author
|
This is outdated. Will discuss options with SQL team. |
github-project-automation
bot
moved this from In Progress
to Done
in Azure MCP Server (OLD)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding first Azure SQL command that will be useful for developers wanting to improve their SQL implementation.
User Scenario: "help me optimize my azure sql db"
This tool will return optimization recommendations from sql advisor.