Address PR feedback: fix JsonSourceGenerationContext duplicate, remove default server name, remove launchSettings, update telemetry constants and property names, clean up InternalsVisibleTo, remove dotnet-install.sh

Co-authored-by: hallipr <[email protected]>

Author: Copilot

core/src/AzureMcp.Core/Services/Telemetry/AzureTelemetryConstants.cs

@@ -0,0 +1,16 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+namespace AzureMcp.Core.Services.Telemetry;
+
+internal static class AzureTelemetryConstants
+{
+    /// <summary>
+    /// Azure-specific telemetry tag names.
+    /// </summary>
+    internal class TagName
+    {
+        public const string ResourceHash = "AzResourceHash";
+        public const string SubscriptionGuid = "AzSubscriptionGuid";
+    }
+}

core/src/Microsoft.Mcp.Core/AssemblyInfo.cs

@@ -5,8 +5,4 @@
 
 [assembly: InternalsVisibleTo("Microsoft.Mcp.Core.UnitTests")]
 [assembly: InternalsVisibleTo("Microsoft.Mcp.Core.LiveTests")]
-[assembly: InternalsVisibleTo("Microsoft.Mcp.Tests")]
-[assembly: InternalsVisibleTo("AzureMcp.Core.UnitTests")]
-[assembly: InternalsVisibleTo("AzureMcp.Core.LiveTests")]
-[assembly: InternalsVisibleTo("AzureMcp.Tests")]
 [assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]

core/src/Microsoft.Mcp.Core/Commands/JsonSourceGenerationContext.cs

@@ -11,7 +11,6 @@ namespace Microsoft.Mcp.Core;
 [JsonSerializable(typeof(JsonElement))]
 [JsonSerializable(typeof(List<string>))]
 [JsonSerializable(typeof(List<JsonNode>))]
-[JsonSerializable(typeof(List<JsonNode>))]
 [JsonSourceGenerationOptions(PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase)]
 internal partial class JsonSourceGenerationContext : JsonSerializerContext
 {

core/src/Microsoft.Mcp.Core/Configuration/McpServerConfiguration.cs

@@ -5,10 +5,8 @@ namespace Microsoft.Mcp.Core.Configuration;
 
 public sealed class McpServerConfiguration
 {
-    public const string DefaultName = "Microsoft.Mcp.Server";
-
-    public string Name { get; set; } = DefaultName;
+    public string Name { get; set; } = string.Empty;
     public string? Version { get; set; }
     public string? UserAgent { get; set; }
-    public bool EnableTelemetry { get; set; } = true;
+    public bool IsTelemetryEnabled { get; set; } = true;
 }

core/src/Microsoft.Mcp.Core/Properties/launchSettings.json

@@ -10,15 +10,13 @@ internal static class TelemetryConstants
     /// </summary>
     internal class TagName
     {
-        public const string McpVersion = "Version";
+        public const string ProductVersion = "ProductVersion";
         public const string ClientName = "ClientName";
         public const string ClientVersion = "ClientVersion";
         public const string DevDeviceId = "DevDeviceId";
         public const string ErrorDetails = "ErrorDetails";
         public const string EventId = "EventId";
         public const string MacAddressHash = "MacAddressHash";
-        public const string ResourceHash = "ResourceHash";
-        public const string SubscriptionGuid = "SubscriptionGuid";
         public const string ToolName = "ToolName";
     }
 

core/src/Microsoft.Mcp.Core/Services/Telemetry/TelemetryConstants.cs

@@ -23,10 +23,10 @@ internal class TelemetryService : ITelemetryService
 
     public TelemetryService(IMachineInformationProvider informationProvider, IOptions<McpServerConfiguration> options)
     {
-        _isEnabled = options.Value.EnableTelemetry;
+        _isEnabled = options.Value.IsTelemetryEnabled;
         _tagsList = new List<KeyValuePair<string, object?>>()
         {
-            new(TagName.McpVersion, options.Value.Version),
+            new(TagName.ProductVersion, options.Value.Version),
         };
 
         Parent = new ActivitySource(options.Value.Name, options.Value.Version, _tagsList);