Skip to content

Conversation

@ssa3512
Copy link
Contributor

@ssa3512 ssa3512 commented Apr 2, 2021

Fixes #64

@ssa3512
Copy link
Contributor Author

ssa3512 commented Apr 2, 2021

@justinyoo can you take a look at this and see if you agree this resolves the issue? I want to try and get some unit tests around this method before merging to make sure I am not inadvertently changing anything else

@justinyoo
Copy link
Contributor

What a coincidence! I started looking at this issue last night! Let me have a look.

@justinyoo
Copy link
Contributor

@ssa3512 That's a great catch. Thanks! It would be great if you can add some test codes around this, and it will be good to go!

@justinyoo justinyoo added bug Something isn't working v0.6.0 labels Apr 3, 2021
@ssa3512 ssa3512 marked this pull request as ready for review April 6, 2021 02:08
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@justinyoo justinyoo merged commit 7f70286 into Azure:main Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generics not recognized well with OpenApiResponseWithBodyAttribute

3 participants