Skip to content

Fix uint32 error #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinyoo merged 2 commits into from
Oct 18, 2021
Merged

Fix uint32 error #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eac9e89
fix uint32 error
Deserve82 Oct 17, 2021
47bc562
fix uint32 test
Deserve82 Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/UInt32TypeVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public override bool IsVisitable(Type type)
/// <inheritdoc />
public override void Visit(IAcceptor acceptor, KeyValuePair<string, Type> type, NamingStrategy namingStrategy, params Attribute[] attributes)
{
this.Visit(acceptor, name: type.Key, title: null, dataType: "integer", dataFormat: null, attributes: attributes);
this.Visit(acceptor, name: type.Key, title: null, dataType: "integer", dataFormat: "int32", attributes: attributes);
}

/// <inheritdoc />
Expand All @@ -46,7 +46,7 @@ public override bool IsParameterVisitable(Type type)
/// <inheritdoc />
public override OpenApiSchema ParameterVisit(Type type, NamingStrategy namingStrategy)
{
return this.ParameterVisit(dataType: "integer", dataFormat: null);
return this.ParameterVisit(dataType: "integer", dataFormat: "int32");
}

/// <inheritdoc />
Expand All @@ -60,7 +60,7 @@ public override bool IsPayloadVisitable(Type type)
/// <inheritdoc />
public override OpenApiSchema PayloadVisit(Type type, NamingStrategy namingStrategy)
{
return this.PayloadVisit(dataType: "integer", dataFormat: null);
return this.PayloadVisit(dataType: "integer", dataFormat: "int32");
}
}
}
6 changes: 3 additions & 3 deletions .../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/UInt32TypeVisitorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void Given_Type_When_IsPayloadVisitable_Invoked_Then_It_Should_Return_Res
}

[DataTestMethod]
[DataRow("integer", null)]
[DataRow("integer", "int32")]
public void Given_Type_When_Visit_Invoked_Then_It_Should_Return_Result(string dataType, string dataFormat)
{
var name = "hello";
Expand Down Expand Up @@ -204,7 +204,7 @@ public void Given_OpenApiSchemaVisibilityAttribute_When_Visit_Invoked_Then_It_Sh
}

[DataTestMethod]
[DataRow("integer", null)]
[DataRow("integer", "int32")]
public void Given_Type_When_ParameterVisit_Invoked_Then_It_Should_Return_Result(string dataType, string dataFormat)
{
var result = this._visitor.ParameterVisit(typeof(uint), this._strategy);
Expand All @@ -214,7 +214,7 @@ public void Given_Type_When_ParameterVisit_Invoked_Then_It_Should_Return_Result(
}

[DataTestMethod]
[DataRow("integer", null)]
[DataRow("integer", "int32")]
public void Given_Type_When_PayloadVisit_Invoked_Then_It_Should_Return_Result(string dataType, string dataFormat)
{
var result = this._visitor.PayloadVisit(typeof(uint), this._strategy);
Expand Down