From 6f846081fd2d19c351efada3562094ea385a351f Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Mon, 28 Nov 2022 12:40:27 -0800
Subject: [PATCH 01/10] initial wip

---
 .../FunctionMetadataProviderGenerator.cs      | 20 +++++++++++++------
 .../Properties/launchSettings.json            |  4 ++++
 sdk/Sdk.Generators/Sdk.Generators.csproj      |  4 ++++
 3 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
index 1bf803c49..efe7aab83 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
@@ -26,15 +26,23 @@ public void Execute(GeneratorExecutionContext context)
 
             // attempt to parse user compilation
             var p = new Parser(context);
-            IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
 
-            // Proceed to generate the file if function metadata info was successfully returned
-            if (functionMetadataInfo.Count > 0)
+            context.AnalyzerConfigOptions.GlobalOptions.TryGetValue("build_property.FunctionsDisableFuncMetadataSourceGen", out var sourceGenSwitch);
+
+            bool.TryParse(sourceGenSwitch, out bool disableSourceGen);
+
+            if (!disableSourceGen)
             {
-                var e = new Emitter();
-                string result = e.Emit(functionMetadataInfo, context.CancellationToken);
+                IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
 
-                context.AddSource($"GeneratedFunctionMetadataProvider.g.cs", SourceText.From(result, Encoding.UTF8));
+                // Proceed to generate the file if function metadata info was successfully returned
+                if (functionMetadataInfo.Count > 0)
+                {
+                    var e = new Emitter();
+                    string result = e.Emit(functionMetadataInfo, context.CancellationToken);
+
+                    context.AddSource($"GeneratedFunctionMetadataProvider.g.cs", SourceText.From(result, Encoding.UTF8));
+                }
             }
         }
 
diff --git a/sdk/Sdk.Generators/Properties/launchSettings.json b/sdk/Sdk.Generators/Properties/launchSettings.json
index a90ca0b10..38de405ef 100644
--- a/sdk/Sdk.Generators/Properties/launchSettings.json
+++ b/sdk/Sdk.Generators/Properties/launchSettings.json
@@ -1,6 +1,10 @@
 {
   "profiles": {
+<<<<<<< HEAD
     "SourceGenDebug": {
+=======
+    "Source Generator": {
+>>>>>>> 3c1c792 (initial wip)
       "commandName": "DebugRoslynComponent",
       "targetProject": "..\\..\\samples\\FunctionApp\\FunctionApp.csproj"
     }
diff --git a/sdk/Sdk.Generators/Sdk.Generators.csproj b/sdk/Sdk.Generators/Sdk.Generators.csproj
index 9e8211cc8..67665a4d2 100644
--- a/sdk/Sdk.Generators/Sdk.Generators.csproj
+++ b/sdk/Sdk.Generators/Sdk.Generators.csproj
@@ -35,4 +35,8 @@
     <None Include="$(PKGSystem_Text_Encodings_Web)\lib\netstandard2.0\*.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
   </ItemGroup>
 
+  <ItemGroup>
+    <CompilerVisibleProperty Include="FunctionsDisableFunctionMetadataSourceGeneration" />
+  </ItemGroup>
+
 </Project>
\ No newline at end of file

From a89d460fe703a5c7968439eedd1e376f87766c7a Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Mon, 28 Nov 2022 12:44:51 -0800
Subject: [PATCH 02/10] sdk target and props changes

---
 sdk/Sdk.Generators/Sdk.Generators.csproj                     | 5 -----
 sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props   | 3 +++
 sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets | 1 +
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/sdk/Sdk.Generators/Sdk.Generators.csproj b/sdk/Sdk.Generators/Sdk.Generators.csproj
index 67665a4d2..08c08cc40 100644
--- a/sdk/Sdk.Generators/Sdk.Generators.csproj
+++ b/sdk/Sdk.Generators/Sdk.Generators.csproj
@@ -34,9 +34,4 @@
     <None Include="$(PKGMicrosoft_Bcl_AsyncInterfaces)\lib\netstandard2.0\*.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
     <None Include="$(PKGSystem_Text_Encodings_Web)\lib\netstandard2.0\*.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
   </ItemGroup>
-
-  <ItemGroup>
-    <CompilerVisibleProperty Include="FunctionsDisableFunctionMetadataSourceGeneration" />
-  </ItemGroup>
-
 </Project>
\ No newline at end of file
diff --git a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
index b60e95325..ae5a1bedd 100644
--- a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
+++ b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
@@ -20,6 +20,9 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
         <ProjectCapability Include="AzureFunctions"/>
   </ItemGroup>
 
+  <ItemGroup>
+    <CompilerVisibleProperty Include="FunctionsDisableFuncMetadataSourceGen" />
+  </ItemGroup>
 <!--
   ***********************************************************************************************
   Import the Publish Props
diff --git a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
index af1b7d48d..835e46fd4 100644
--- a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
+++ b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
@@ -34,6 +34,7 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
         <MSBuildFunctionsTargetsPath>$(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed.Functions\</MSBuildFunctionsTargetsPath>
       
         <FunctionsEnableWorkerIndexing Condition="$(FunctionsEnableWorkerIndexing) == ''">false</FunctionsEnableWorkerIndexing>
+        <FunctionsDisableFuncMetadataSourceGen Condition="$(FunctionsDisableFuncMetadataSourceGen) == ''">false</FunctionsDisableFuncMetadataSourceGen>
     </PropertyGroup>
 
     <UsingTask TaskName="GenerateFunctionMetadata"

From 37f089b358fc1e1836de40db1e23e27ab98c6f6c Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Thu, 1 Dec 2022 13:34:41 -0800
Subject: [PATCH 03/10] fix launch settings

---
 sdk/Sdk.Generators/Properties/launchSettings.json | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sdk/Sdk.Generators/Properties/launchSettings.json b/sdk/Sdk.Generators/Properties/launchSettings.json
index 38de405ef..e52c14c1b 100644
--- a/sdk/Sdk.Generators/Properties/launchSettings.json
+++ b/sdk/Sdk.Generators/Properties/launchSettings.json
@@ -1,10 +1,6 @@
 {
   "profiles": {
-<<<<<<< HEAD
-    "SourceGenDebug": {
-=======
     "Source Generator": {
->>>>>>> 3c1c792 (initial wip)
       "commandName": "DebugRoslynComponent",
       "targetProject": "..\\..\\samples\\FunctionApp\\FunctionApp.csproj"
     }

From f23f399445a6a652d3219c9bac59442e9e0aa5c6 Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Wed, 14 Dec 2022 13:13:59 -0800
Subject: [PATCH 04/10] resolve comments

---
 sdk/Sdk.Generators/Constants.cs               |  6 +++++
 .../FunctionMetadataProviderGenerator.cs      | 24 ++++++++++---------
 .../Properties/launchSettings.json            |  2 +-
 ...Microsoft.Azure.Functions.Worker.Sdk.props |  2 +-
 4 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/sdk/Sdk.Generators/Constants.cs b/sdk/Sdk.Generators/Constants.cs
index 0d98a856a..56c30a2cd 100644
--- a/sdk/Sdk.Generators/Constants.cs
+++ b/sdk/Sdk.Generators/Constants.cs
@@ -5,6 +5,12 @@ namespace Microsoft.Azure.Functions.Worker.Sdk.Generators
 {
     internal static class Constants
     {
+        // MSBuild Props
+        internal const string EnableSourceGenProp = "build_property.FunctionsMetadataSourceGen_Enabled";
+
+        // Generated File Names
+        internal const string GeneratedFunctionMetadataFileName = "GeneratedFunctionMetadataProvider.g.cs";
+
         // Our types
         internal const string BindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingAttribute";
         internal const string OutputBindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.OutputBindingAttribute";
diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
index efe7aab83..da8ac6465 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
@@ -27,22 +27,24 @@ public void Execute(GeneratorExecutionContext context)
             // attempt to parse user compilation
             var p = new Parser(context);
 
-            context.AnalyzerConfigOptions.GlobalOptions.TryGetValue("build_property.FunctionsDisableFuncMetadataSourceGen", out var sourceGenSwitch);
+            context.AnalyzerConfigOptions.GlobalOptions.TryGetValue(Constants.EnableSourceGenProp, out var sourceGenSwitch);
 
-            bool.TryParse(sourceGenSwitch, out bool disableSourceGen);
+            bool.TryParse(sourceGenSwitch, out bool enableSourceGen);
 
-            if (!disableSourceGen)
+            if (!enableSourceGen)
             {
-                IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
+                return;
+            }
 
-                // Proceed to generate the file if function metadata info was successfully returned
-                if (functionMetadataInfo.Count > 0)
-                {
-                    var e = new Emitter();
-                    string result = e.Emit(functionMetadataInfo, context.CancellationToken);
+            IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
 
-                    context.AddSource($"GeneratedFunctionMetadataProvider.g.cs", SourceText.From(result, Encoding.UTF8));
-                }
+            // Proceed to generate the file if function metadata info was successfully returned
+            if (functionMetadataInfo.Count > 0)
+            {
+                Emitter e = new();
+                string result = e.Emit(functionMetadataInfo, context.CancellationToken);
+
+                context.AddSource(Constants.GeneratedFunctionMetadataFileName, SourceText.From(result, Encoding.UTF8));
             }
         }
 
diff --git a/sdk/Sdk.Generators/Properties/launchSettings.json b/sdk/Sdk.Generators/Properties/launchSettings.json
index e52c14c1b..55769ef01 100644
--- a/sdk/Sdk.Generators/Properties/launchSettings.json
+++ b/sdk/Sdk.Generators/Properties/launchSettings.json
@@ -1,6 +1,6 @@
 {
   "profiles": {
-    "Source Generator": {
+    "SourceGenerator": {
       "commandName": "DebugRoslynComponent",
       "targetProject": "..\\..\\samples\\FunctionApp\\FunctionApp.csproj"
     }
diff --git a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
index ae5a1bedd..239d53a8f 100644
--- a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
+++ b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.props
@@ -21,7 +21,7 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
   </ItemGroup>
 
   <ItemGroup>
-    <CompilerVisibleProperty Include="FunctionsDisableFuncMetadataSourceGen" />
+    <CompilerVisibleProperty Include="FunctionsMetadataSourceGen_Enabled" />
   </ItemGroup>
 <!--
   ***********************************************************************************************

From 8d8884016bb25fdae963fdc4d56b08455ef67b34 Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Wed, 14 Dec 2022 13:18:15 -0800
Subject: [PATCH 05/10] resolve comments

---
 sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
index 835e46fd4..0697f4c93 100644
--- a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
+++ b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
@@ -34,7 +34,7 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
         <MSBuildFunctionsTargetsPath>$(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed.Functions\</MSBuildFunctionsTargetsPath>
       
         <FunctionsEnableWorkerIndexing Condition="$(FunctionsEnableWorkerIndexing) == ''">false</FunctionsEnableWorkerIndexing>
-        <FunctionsDisableFuncMetadataSourceGen Condition="$(FunctionsDisableFuncMetadataSourceGen) == ''">false</FunctionsDisableFuncMetadataSourceGen>
+        <FunctionsDisableFuncMetadataSourceGen Condition="$(FunctionsMetadataSourceGen_Enabled) == ''">true</FunctionsDisableFuncMetadataSourceGen>
     </PropertyGroup>
 
     <UsingTask TaskName="GenerateFunctionMetadata"

From fd949a667090d4d963befe0e00533aacad0d139f Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Tue, 3 Jan 2023 09:36:08 -0800
Subject: [PATCH 06/10] resolve comments, refactor constants

---
 sdk/Sdk.Generators/Constants.cs               | 75 +++++++++++--------
 ...unctionMetadataProviderGenerator.Parser.cs | 74 +++++++++---------
 .../FunctionMetadataProviderGenerator.cs      |  4 +-
 ...crosoft.Azure.Functions.Worker.Sdk.targets |  2 +-
 4 files changed, 82 insertions(+), 73 deletions(-)

diff --git a/sdk/Sdk.Generators/Constants.cs b/sdk/Sdk.Generators/Constants.cs
index 56c30a2cd..67822afed 100644
--- a/sdk/Sdk.Generators/Constants.cs
+++ b/sdk/Sdk.Generators/Constants.cs
@@ -5,41 +5,50 @@ namespace Microsoft.Azure.Functions.Worker.Sdk.Generators
 {
     internal static class Constants
     {
-        // MSBuild Props
-        internal const string EnableSourceGenProp = "build_property.FunctionsMetadataSourceGen_Enabled";
+        public static class BuildProperties
+        {
+            internal const string EnableSourceGenProp = "build_property.FunctionsMetadataSourceGen_Enabled";
+        }
 
-        // Generated File Names
-        internal const string GeneratedFunctionMetadataFileName = "GeneratedFunctionMetadataProvider.g.cs";
+        public static class FileNames
+        {
+            internal const string GeneratedFunctionMetadataFileName = "GeneratedFunctionMetadataProvider.g.cs";
+        }
 
-        // Our types
-        internal const string BindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingAttribute";
-        internal const string OutputBindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.OutputBindingAttribute";
-        internal const string FunctionNameType = "Microsoft.Azure.Functions.Worker.FunctionAttribute";
-        internal const string HttpResponseType = "Microsoft.Azure.Functions.Worker.Http.HttpResponseData";
-        internal const string EventHubsTriggerType = "Microsoft.Azure.Functions.Worker.EventHubTriggerAttribute";
-        internal const string BindingPropertyNameAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingPropertyNameAttribute";
-        internal const string DefaultValueType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.DefaultValueAttribute";
+        public static class Types
+        {
+            // Our types
+            internal const string BindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingAttribute";
+            internal const string OutputBindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.OutputBindingAttribute";
+            internal const string FunctionNameType = "Microsoft.Azure.Functions.Worker.FunctionAttribute";
+            internal const string HttpResponseType = "Microsoft.Azure.Functions.Worker.Http.HttpResponseData";
+            internal const string HttpTriggerBindingType = "Microsoft.Azure.Functions.Worker.HttpTriggerAttribute";
+            internal const string EventHubsTriggerType = "Microsoft.Azure.Functions.Worker.EventHubTriggerAttribute";
+            internal const string BindingPropertyNameAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingPropertyNameAttribute";
+            internal const string DefaultValueType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.DefaultValueAttribute";
 
-        // System types
-        internal const string IEnumerableType = "System.Collections.IEnumerable";
-        internal const string IEnumerableGenericType = "System.Collections.Generic.IEnumerable`1";
-        internal const string IEnumerableOfStringType = "System.Collections.Generic.IEnumerable`1<System.String>";
-        internal const string IEnumerableOfBinaryType = "System.Collections.Generic.IEnumerable`1<System.Byte[]>";
-        internal const string IEnumerableOfT = "System.Collections.Generic.IEnumerable`1<T>";
-        internal const string IEnumerableOfKeyValuePair = "System.Collections.Generic.IEnumerable`1<System.Collections.Generic.KeyValuePair`2<TKey,TValue>>";
-        internal const string StringType = "System.String";
-        internal const string ByteArrayType = "System.Byte[]";
-        internal const string ByteStructType = "System.Byte";
-        internal const string TaskGenericType = "System.Threading.Tasks.Task`1";
-        internal const string TaskType = "System.Threading.Tasks.Task";
-        internal const string VoidType = "System.Void";
-        internal const string ReadOnlyMemoryOfBytes = "System.ReadOnlyMemory`1<System.Byte>";
-        internal const string LookupGenericType = "System.Linq.Lookup`2";
-        internal const string DictionaryGenericType = "System.Collections.Generic.Dictionary`2";
-
-        internal const string ReturnBindingName = "$return";
-        internal const string HttpResponseBindingName = "HttpResponse";
-        internal const string HttpTriggerBindingType = "Microsoft.Azure.Functions.Worker.HttpTriggerAttribute";
-        internal const string IsBatchedKey = "IsBatched";
+            // System types
+            internal const string IEnumerableType = "System.Collections.IEnumerable";
+            internal const string IEnumerableGenericType = "System.Collections.Generic.IEnumerable`1";
+            internal const string IEnumerableOfStringType = "System.Collections.Generic.IEnumerable`1<System.String>";
+            internal const string IEnumerableOfBinaryType = "System.Collections.Generic.IEnumerable`1<System.Byte[]>";
+            internal const string IEnumerableOfT = "System.Collections.Generic.IEnumerable`1<T>";
+            internal const string IEnumerableOfKeyValuePair = "System.Collections.Generic.IEnumerable`1<System.Collections.Generic.KeyValuePair`2<TKey,TValue>>";
+            internal const string StringType = "System.String";
+            internal const string ByteArrayType = "System.Byte[]";
+            internal const string ByteStructType = "System.Byte";
+            internal const string TaskGenericType = "System.Threading.Tasks.Task`1";
+            internal const string TaskType = "System.Threading.Tasks.Task";
+            internal const string VoidType = "System.Void";
+            internal const string ReadOnlyMemoryOfBytes = "System.ReadOnlyMemory`1<System.Byte>";
+            internal const string LookupGenericType = "System.Linq.Lookup`2";
+            internal const string DictionaryGenericType = "System.Collections.Generic.Dictionary`2";
+        }
+        
+        public static class FunctionMetadataBindingProps {
+            internal const string ReturnBindingName = "$return";
+            internal const string HttpResponseBindingName = "HttpResponse";
+            internal const string IsBatchedKey = "IsBatched";
+        }
     }
 }
diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
index 39e15ec02..afbbb954a 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
@@ -99,7 +99,7 @@ private bool IsValidMethodAzureFunction(SemanticModel model, MethodDeclarationSy
                 foreach (var attr in methodSymbol.GetAttributes())
                 {
                     if (attr.AttributeClass != null &&
-                       SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.FunctionNameType)))
+                       SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.FunctionNameType)))
                     {
                         functionName = (string)attr.ConstructorArguments.First().Value!; // If this is a function attribute this won't be null
                         return true;
@@ -147,7 +147,7 @@ private bool TryGetMethodOutputBinding(MethodDeclarationSyntax method, SemanticM
 
                 foreach (var attribute in attributes)
                 {
-                    if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.OutputBindingAttributeType)))
+                    if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)))
                     {
                         // There can only be one output binding associated with a function. If there is more than one, we return a diagnostic error here.
                         if (hasOutputBinding)
@@ -164,7 +164,7 @@ private bool TryGetMethodOutputBinding(MethodDeclarationSyntax method, SemanticM
 
                 if (outputBindingAttribute != null)
                 {
-                    if (!TryCreateBindingDict(outputBindingAttribute, Constants.ReturnBindingName, bindingLocation, out IDictionary<string, object>? bindingDict))
+                    if (!TryCreateBindingDict(outputBindingAttribute, Constants.FunctionMetadataBindingProps.ReturnBindingName, bindingLocation, out IDictionary<string, object>? bindingDict))
                     {
                         bindingsList = null;
                         return false;
@@ -207,18 +207,18 @@ private bool TryGetParameterInputAndTriggerBindings(MethodDeclarationSyntax meth
                     // Check to see if any of the attributes associated with this parameter is a BindingAttribute
                     foreach (var attribute in parameterSymbol.GetAttributes())
                     {
-                        if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType?.BaseType, Compilation.GetTypeByMetadataName(Constants.BindingAttributeType)))
+                        if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.BindingAttributeType)))
                         {
                             var validEventHubs = false;
                             var cardinality = Cardinality.Undefined;
                             var dataType = GetDataType(parameterSymbol.Type);
 
                             // There are two special cases we need to handle: HttpTrigger and EventHubsTrigger.
-                            if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.HttpTriggerBindingType)))
+                            if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.HttpTriggerBindingType)))
                             {
                                 hasHttpTrigger = true;
                             }
-                            else if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.EventHubsTriggerType)))
+                            else if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.EventHubsTriggerType)))
                             {
                                 // there are special rules for EventHubsTriggers that we will have to validate
                                 validEventHubs = IsEventHubsTriggerValid(parameterSymbol, parameter.Type, model, attribute, out dataType, out cardinality);
@@ -276,11 +276,11 @@ private bool TryGetReturnTypeBindings(MethodDeclarationSyntax method, SemanticMo
                     return false;
                 }
 
-                if (!SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.VoidType)) &&
-                    !SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.TaskType)))
+                if (!SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.VoidType)) &&
+                    !SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.TaskType)))
                 {
                     // If there is a Task<T> return type, inspect T, the inner type.
-                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.TaskGenericType))) 
+                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.TaskGenericType))) 
                     {
                         GenericNameSyntax genericSyntax = (GenericNameSyntax)returnTypeSyntax;
                         var innerTypeSyntax = genericSyntax.TypeArgumentList.Arguments.First(); // Generic task should only have one type argument
@@ -294,9 +294,9 @@ private bool TryGetReturnTypeBindings(MethodDeclarationSyntax method, SemanticMo
                         }
                     }
 
-                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.HttpResponseType))) // If return type is HttpResponseData
+                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponseType))) // If return type is HttpResponseData
                     {
-                        bindingsList.Add(GetHttpReturnBinding(Constants.ReturnBindingName));
+                        bindingsList.Add(GetHttpReturnBinding(Constants.FunctionMetadataBindingProps.ReturnBindingName));
                     }
                     else
                     {
@@ -327,7 +327,7 @@ private bool TryGetReturnTypePropertyBindings(ITypeSymbol returnTypeSymbol, bool
                     }
 
                     // Check if this attribute is an HttpResponseData type attribute
-                    if (prop is IPropertySymbol property && SymbolEqualityComparer.Default.Equals(property.Type, Compilation.GetTypeByMetadataName(Constants.HttpResponseType)))
+                    if (prop is IPropertySymbol property && SymbolEqualityComparer.Default.Equals(property.Type, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponseType)))
                     {
                         if (foundHttpOutput)
                         {
@@ -345,7 +345,7 @@ private bool TryGetReturnTypePropertyBindings(ITypeSymbol returnTypeSymbol, bool
 
                         foreach (var attr in prop.GetAttributes()) // now loop through and check if any of the attributes are Binding attributes
                         {
-                            if (SymbolEqualityComparer.Default.Equals(attr.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.OutputBindingAttributeType)))
+                            if (SymbolEqualityComparer.Default.Equals(attr.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)))
                             {
                                 // validate that there's only one binding attribute per property
                                 if (foundPropertyOutputAttr)
@@ -374,11 +374,11 @@ private bool TryGetReturnTypePropertyBindings(ITypeSymbol returnTypeSymbol, bool
                 {
                     if (!hasOutputBinding)
                     {
-                        bindingsList.Add(GetHttpReturnBinding(Constants.ReturnBindingName));
+                        bindingsList.Add(GetHttpReturnBinding(Constants.FunctionMetadataBindingProps.ReturnBindingName));
                     }
                     else
                     {
-                        bindingsList.Add(GetHttpReturnBinding(Constants.HttpResponseBindingName));
+                        bindingsList.Add(GetHttpReturnBinding(Constants.FunctionMetadataBindingProps.HttpResponseBindingName));
                     }
                 }
 
@@ -413,7 +413,7 @@ private bool TryCreateBindingDict(AttributeData bindingAttrData, string bindingN
                 string bindingType = attributeName.TrimStringsFromEnd(_functionsStringNamesToRemove);
 
                 // Set binding direction
-                string bindingDirection = SymbolEqualityComparer.Default.Equals(bindingAttrData.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.OutputBindingAttributeType)) ? "Out" : "In";
+                string bindingDirection = SymbolEqualityComparer.Default.Equals(bindingAttrData.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)) ? "Out" : "In";
 
                 var bindingCount = attributeProperties!.Count + 3;
                 bindings = new Dictionary<string, object>(capacity: bindingCount)
@@ -458,7 +458,7 @@ private bool TryGetAttributeProperties(AttributeData attributeData, Location? at
                 {
                     if (namedArgument.Value.Value != null)
                     {
-                        if (string.Equals(namedArgument.Key, Constants.IsBatchedKey) && !attrProperties.ContainsKey("cardinality"))
+                        if (string.Equals(namedArgument.Key, Constants.FunctionMetadataBindingProps.IsBatchedKey) && !attrProperties.ContainsKey("cardinality"))
                         {
                             var argValue = (bool)namedArgument.Value.Value; // isBatched only takes in booleans and the generator will parse it as a bool so we can type cast this to use in the next line
 
@@ -474,13 +474,13 @@ private bool TryGetAttributeProperties(AttributeData attributeData, Location? at
                 // some properties have default values, so if these properties were not already defined in constructor or named arguments, we will auto-add them here
                 foreach (var member in attributeData.AttributeClass!.GetMembers().Where(a => a is IPropertySymbol))
                 {
-                    var defaultValAttrList = member.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.DefaultValueType)));
+                    var defaultValAttrList = member.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValueType)));
 
                     if (defaultValAttrList.SingleOrDefault() is { } defaultValAttr) // list will only be of size one b/c there cannot be duplicates of an attribute on one piece of syntax
                     {
                         var argName = member.Name;
                         object arg = defaultValAttr.ConstructorArguments.SingleOrDefault().Value!; // only one constructor arg in DefaultValue attribute (the default value)
-                        if (arg is bool b && string.Equals(argName, Constants.IsBatchedKey))
+                        if (arg is bool b && string.Equals(argName, Constants.FunctionMetadataBindingProps.IsBatchedKey))
                         {
                             if (!attrProperties.Keys.Contains("cardinality"))
                             {
@@ -546,7 +546,7 @@ private bool TryLoadConstructorArguments(AttributeData attributeData, IDictionar
 
             private void OverrideBindingName(INamedTypeSymbol attributeClass, ref string argumentName)
             {
-                var bindingPropertyNameSymbol = Compilation.GetTypeByMetadataName(Constants.BindingPropertyNameAttributeType);
+                var bindingPropertyNameSymbol = Compilation.GetTypeByMetadataName(Constants.Types.BindingPropertyNameAttributeType);
 
                 foreach (var prop in attributeClass.GetMembers().Where(a => a is IPropertySymbol))
                 {
@@ -574,7 +574,7 @@ private bool IsEventHubsTriggerValid(IParameterSymbol parameterSymbol, TypeSynta
                 // check if IsBatched is defined in the NamedArguments
                 foreach (var arg in attribute.NamedArguments)
                 {
-                    if (String.Equals(arg.Key, Constants.IsBatchedKey) &&
+                    if (String.Equals(arg.Key, Constants.FunctionMetadataBindingProps.IsBatchedKey) &&
                         arg.Value.Value != null)
                     {
                         var isBatched = (bool)arg.Value.Value; // isBatched takes in booleans so we can just type cast it here to use
@@ -590,8 +590,8 @@ private bool IsEventHubsTriggerValid(IParameterSymbol parameterSymbol, TypeSynta
 
                 // Check the default value of IsBatched
                 var eventHubsAttr = attribute.AttributeClass;
-                var isBatchedProp = eventHubsAttr!.GetMembers().Where(m => string.Equals(m.Name, Constants.IsBatchedKey, StringComparison.OrdinalIgnoreCase)).SingleOrDefault();
-                AttributeData defaultValAttr = isBatchedProp.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.DefaultValueType))).SingleOrDefault();
+                var isBatchedProp = eventHubsAttr!.GetMembers().Where(m => string.Equals(m.Name, Constants.FunctionMetadataBindingProps.IsBatchedKey, StringComparison.OrdinalIgnoreCase)).SingleOrDefault();
+                AttributeData defaultValAttr = isBatchedProp.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValueType))).SingleOrDefault();
                 var defaultVal = defaultValAttr.ConstructorArguments.SingleOrDefault().Value!.ToString(); // there is only one constructor arg, the default value
                 if (!bool.TryParse(defaultVal, out bool b) || !b)
                 {
@@ -602,20 +602,20 @@ private bool IsEventHubsTriggerValid(IParameterSymbol parameterSymbol, TypeSynta
 
                 // we check if the param is an array type
                 // we exclude byte arrays (byte[]) b/c we handle that as cardinality one (we handle this simliar to how a char[] is basically a string)
-                if (parameterSymbol.Type is IArrayTypeSymbol && !SymbolEqualityComparer.Default.Equals(parameterSymbol.Type, Compilation.GetTypeByMetadataName(Constants.ByteArrayType)))
+                if (parameterSymbol.Type is IArrayTypeSymbol && !SymbolEqualityComparer.Default.Equals(parameterSymbol.Type, Compilation.GetTypeByMetadataName(Constants.Types.ByteArrayType)))
                 {
                     dataType = GetDataType(parameterSymbol.Type);
                     cardinality = Cardinality.Many;
                     return true;
                 }
 
-                var isGenericEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.IEnumerableGenericType));
-                var isEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.IEnumerableType));
+                var isGenericEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType));
+                var isEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableType));
 
                 // Check if mapping type - mapping enumerables are not valid types for EventHubParameters
-                if (parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.IEnumerableOfKeyValuePair))
-                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.LookupGenericType))
-                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.DictionaryGenericType)))
+                if (parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableOfKeyValuePair))
+                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.LookupGenericType))
+                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.DictionaryGenericType)))
                 {
                     return false;
                 }
@@ -671,13 +671,13 @@ private DataType ResolveIEnumerableOfT(IParameterSymbol parameterSymbol, TypeSyn
                 {
                     INamedTypeSymbol? genericInterfaceSymbol = null;
 
-                    if (currSymbol.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.IEnumerableGenericType)) && currSymbol is INamedTypeSymbol currNamedSymbol)
+                    if (currSymbol.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType)) && currSymbol is INamedTypeSymbol currNamedSymbol)
                     {
                         finalSymbol = currNamedSymbol;
                         break;
                     }
 
-                    genericInterfaceSymbol = currSymbol.Interfaces.Where(i => i.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.IEnumerableGenericType))).FirstOrDefault();
+                    genericInterfaceSymbol = currSymbol.Interfaces.Where(i => i.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType))).FirstOrDefault();
                     if (genericInterfaceSymbol != null)
                     {
                         finalSymbol = genericInterfaceSymbol;
@@ -721,17 +721,17 @@ private DataType GetDataType(ITypeSymbol symbol)
 
             private bool IsStringType(ITypeSymbol symbol)
             {
-                return SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.StringType))
-                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.StringType)));
+                return SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.StringType))
+                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.StringType)));
             }
 
             private bool IsBinaryType(ITypeSymbol symbol)
             {
-                var isByteArray = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.ByteArrayType))
-                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.ByteStructType)));
-                var isReadOnlyMemoryOfBytes = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.ReadOnlyMemoryOfBytes));
+                var isByteArray = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.ByteArrayType))
+                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStructType)));
+                var isReadOnlyMemoryOfBytes = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.ReadOnlyMemoryOfBytes));
                 var isArrayOfByteArrays = symbol is IArrayTypeSymbol outerArray && 
-                    outerArray.ElementType is IArrayTypeSymbol innerArray && SymbolEqualityComparer.Default.Equals(innerArray.ElementType, Compilation.GetTypeByMetadataName(Constants.ByteStructType));
+                    outerArray.ElementType is IArrayTypeSymbol innerArray && SymbolEqualityComparer.Default.Equals(innerArray.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStructType));
 
 
                 return isByteArray || isReadOnlyMemoryOfBytes || isArrayOfByteArrays;
diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
index da8ac6465..e6afc5d65 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
@@ -27,7 +27,7 @@ public void Execute(GeneratorExecutionContext context)
             // attempt to parse user compilation
             var p = new Parser(context);
 
-            context.AnalyzerConfigOptions.GlobalOptions.TryGetValue(Constants.EnableSourceGenProp, out var sourceGenSwitch);
+            context.AnalyzerConfigOptions.GlobalOptions.TryGetValue(Constants.BuildProperties.EnableSourceGenProp, out var sourceGenSwitch);
 
             bool.TryParse(sourceGenSwitch, out bool enableSourceGen);
 
@@ -44,7 +44,7 @@ public void Execute(GeneratorExecutionContext context)
                 Emitter e = new();
                 string result = e.Emit(functionMetadataInfo, context.CancellationToken);
 
-                context.AddSource(Constants.GeneratedFunctionMetadataFileName, SourceText.From(result, Encoding.UTF8));
+                context.AddSource(Constants.FileNames.GeneratedFunctionMetadataFileName, SourceText.From(result, Encoding.UTF8));
             }
         }
 
diff --git a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
index 0697f4c93..dfe1cc85b 100644
--- a/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
+++ b/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets
@@ -34,7 +34,7 @@ WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
         <MSBuildFunctionsTargetsPath>$(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed.Functions\</MSBuildFunctionsTargetsPath>
       
         <FunctionsEnableWorkerIndexing Condition="$(FunctionsEnableWorkerIndexing) == ''">false</FunctionsEnableWorkerIndexing>
-        <FunctionsDisableFuncMetadataSourceGen Condition="$(FunctionsMetadataSourceGen_Enabled) == ''">true</FunctionsDisableFuncMetadataSourceGen>
+        <FunctionsMetadataSourceGen_Enabled Condition="$(FunctionsMetadataSourceGen_Enabled) == ''">true</FunctionsMetadataSourceGen_Enabled>
     </PropertyGroup>
 
     <UsingTask TaskName="GenerateFunctionMetadata"

From 3f6d3fb9943193b9c012f54e79e9f46675f17e85 Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Thu, 5 Jan 2023 14:15:40 -0800
Subject: [PATCH 07/10] edit constant names

---
 sdk/Sdk.Generators/Constants.cs               | 42 +++++++--------
 ...unctionMetadataProviderGenerator.Parser.cs | 54 +++++++++----------
 2 files changed, 48 insertions(+), 48 deletions(-)

diff --git a/sdk/Sdk.Generators/Constants.cs b/sdk/Sdk.Generators/Constants.cs
index 67822afed..8dabe2b19 100644
--- a/sdk/Sdk.Generators/Constants.cs
+++ b/sdk/Sdk.Generators/Constants.cs
@@ -12,37 +12,37 @@ public static class BuildProperties
 
         public static class FileNames
         {
-            internal const string GeneratedFunctionMetadataFileName = "GeneratedFunctionMetadataProvider.g.cs";
+            internal const string GeneratedFunctionMetadata = "GeneratedFunctionMetadataProvider.g.cs";
         }
 
         public static class Types
         {
             // Our types
-            internal const string BindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingAttribute";
-            internal const string OutputBindingAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.OutputBindingAttribute";
-            internal const string FunctionNameType = "Microsoft.Azure.Functions.Worker.FunctionAttribute";
-            internal const string HttpResponseType = "Microsoft.Azure.Functions.Worker.Http.HttpResponseData";
-            internal const string HttpTriggerBindingType = "Microsoft.Azure.Functions.Worker.HttpTriggerAttribute";
-            internal const string EventHubsTriggerType = "Microsoft.Azure.Functions.Worker.EventHubTriggerAttribute";
-            internal const string BindingPropertyNameAttributeType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingPropertyNameAttribute";
-            internal const string DefaultValueType = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.DefaultValueAttribute";
+            internal const string BindingAttribute = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingAttribute";
+            internal const string OutputBindingAttribute = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.OutputBindingAttribute";
+            internal const string FunctionName = "Microsoft.Azure.Functions.Worker.FunctionAttribute";
+            internal const string HttpResponse = "Microsoft.Azure.Functions.Worker.Http.HttpResponseData";
+            internal const string HttpTriggerBinding = "Microsoft.Azure.Functions.Worker.HttpTriggerAttribute";
+            internal const string EventHubsTrigger = "Microsoft.Azure.Functions.Worker.EventHubTriggerAttribute";
+            internal const string BindingPropertyNameAttribute = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.BindingPropertyNameAttribute";
+            internal const string DefaultValue = "Microsoft.Azure.Functions.Worker.Extensions.Abstractions.DefaultValueAttribute";
 
             // System types
-            internal const string IEnumerableType = "System.Collections.IEnumerable";
-            internal const string IEnumerableGenericType = "System.Collections.Generic.IEnumerable`1";
-            internal const string IEnumerableOfStringType = "System.Collections.Generic.IEnumerable`1<System.String>";
-            internal const string IEnumerableOfBinaryType = "System.Collections.Generic.IEnumerable`1<System.Byte[]>";
+            internal const string IEnumerable = "System.Collections.IEnumerable";
+            internal const string IEnumerableGeneric = "System.Collections.Generic.IEnumerable`1";
+            internal const string IEnumerableOfString = "System.Collections.Generic.IEnumerable`1<System.String>";
+            internal const string IEnumerableOfBinary = "System.Collections.Generic.IEnumerable`1<System.Byte[]>";
             internal const string IEnumerableOfT = "System.Collections.Generic.IEnumerable`1<T>";
             internal const string IEnumerableOfKeyValuePair = "System.Collections.Generic.IEnumerable`1<System.Collections.Generic.KeyValuePair`2<TKey,TValue>>";
-            internal const string StringType = "System.String";
-            internal const string ByteArrayType = "System.Byte[]";
-            internal const string ByteStructType = "System.Byte";
-            internal const string TaskGenericType = "System.Threading.Tasks.Task`1";
-            internal const string TaskType = "System.Threading.Tasks.Task";
-            internal const string VoidType = "System.Void";
+            internal const string String = "System.String";
+            internal const string ByteArray = "System.Byte[]";
+            internal const string ByteStruct = "System.Byte";
+            internal const string TaskGeneric = "System.Threading.Tasks.Task`1";
+            internal const string Task = "System.Threading.Tasks.Task";
+            internal const string Void = "System.Void";
             internal const string ReadOnlyMemoryOfBytes = "System.ReadOnlyMemory`1<System.Byte>";
-            internal const string LookupGenericType = "System.Linq.Lookup`2";
-            internal const string DictionaryGenericType = "System.Collections.Generic.Dictionary`2";
+            internal const string LookupGeneric = "System.Linq.Lookup`2";
+            internal const string DictionaryGeneric = "System.Collections.Generic.Dictionary`2";
         }
         
         public static class FunctionMetadataBindingProps {
diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
index afbbb954a..9ce22ee5b 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Parser.cs
@@ -99,7 +99,7 @@ private bool IsValidMethodAzureFunction(SemanticModel model, MethodDeclarationSy
                 foreach (var attr in methodSymbol.GetAttributes())
                 {
                     if (attr.AttributeClass != null &&
-                       SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.FunctionNameType)))
+                       SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.FunctionName)))
                     {
                         functionName = (string)attr.ConstructorArguments.First().Value!; // If this is a function attribute this won't be null
                         return true;
@@ -147,7 +147,7 @@ private bool TryGetMethodOutputBinding(MethodDeclarationSyntax method, SemanticM
 
                 foreach (var attribute in attributes)
                 {
-                    if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)))
+                    if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttribute)))
                     {
                         // There can only be one output binding associated with a function. If there is more than one, we return a diagnostic error here.
                         if (hasOutputBinding)
@@ -207,18 +207,18 @@ private bool TryGetParameterInputAndTriggerBindings(MethodDeclarationSyntax meth
                     // Check to see if any of the attributes associated with this parameter is a BindingAttribute
                     foreach (var attribute in parameterSymbol.GetAttributes())
                     {
-                        if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.BindingAttributeType)))
+                        if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass?.BaseType?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.BindingAttribute)))
                         {
                             var validEventHubs = false;
                             var cardinality = Cardinality.Undefined;
                             var dataType = GetDataType(parameterSymbol.Type);
 
                             // There are two special cases we need to handle: HttpTrigger and EventHubsTrigger.
-                            if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.HttpTriggerBindingType)))
+                            if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.HttpTriggerBinding)))
                             {
                                 hasHttpTrigger = true;
                             }
-                            else if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.EventHubsTriggerType)))
+                            else if (SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.EventHubsTrigger)))
                             {
                                 // there are special rules for EventHubsTriggers that we will have to validate
                                 validEventHubs = IsEventHubsTriggerValid(parameterSymbol, parameter.Type, model, attribute, out dataType, out cardinality);
@@ -276,11 +276,11 @@ private bool TryGetReturnTypeBindings(MethodDeclarationSyntax method, SemanticMo
                     return false;
                 }
 
-                if (!SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.VoidType)) &&
-                    !SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.TaskType)))
+                if (!SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.Void)) &&
+                    !SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.Task)))
                 {
                     // If there is a Task<T> return type, inspect T, the inner type.
-                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.TaskGenericType))) 
+                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.TaskGeneric))) 
                     {
                         GenericNameSyntax genericSyntax = (GenericNameSyntax)returnTypeSyntax;
                         var innerTypeSyntax = genericSyntax.TypeArgumentList.Arguments.First(); // Generic task should only have one type argument
@@ -294,7 +294,7 @@ private bool TryGetReturnTypeBindings(MethodDeclarationSyntax method, SemanticMo
                         }
                     }
 
-                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponseType))) // If return type is HttpResponseData
+                    if (SymbolEqualityComparer.Default.Equals(returnTypeSymbol, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponse))) // If return type is HttpResponseData
                     {
                         bindingsList.Add(GetHttpReturnBinding(Constants.FunctionMetadataBindingProps.ReturnBindingName));
                     }
@@ -327,7 +327,7 @@ private bool TryGetReturnTypePropertyBindings(ITypeSymbol returnTypeSymbol, bool
                     }
 
                     // Check if this attribute is an HttpResponseData type attribute
-                    if (prop is IPropertySymbol property && SymbolEqualityComparer.Default.Equals(property.Type, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponseType)))
+                    if (prop is IPropertySymbol property && SymbolEqualityComparer.Default.Equals(property.Type, Compilation.GetTypeByMetadataName(Constants.Types.HttpResponse)))
                     {
                         if (foundHttpOutput)
                         {
@@ -345,7 +345,7 @@ private bool TryGetReturnTypePropertyBindings(ITypeSymbol returnTypeSymbol, bool
 
                         foreach (var attr in prop.GetAttributes()) // now loop through and check if any of the attributes are Binding attributes
                         {
-                            if (SymbolEqualityComparer.Default.Equals(attr.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)))
+                            if (SymbolEqualityComparer.Default.Equals(attr.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttribute)))
                             {
                                 // validate that there's only one binding attribute per property
                                 if (foundPropertyOutputAttr)
@@ -413,7 +413,7 @@ private bool TryCreateBindingDict(AttributeData bindingAttrData, string bindingN
                 string bindingType = attributeName.TrimStringsFromEnd(_functionsStringNamesToRemove);
 
                 // Set binding direction
-                string bindingDirection = SymbolEqualityComparer.Default.Equals(bindingAttrData.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttributeType)) ? "Out" : "In";
+                string bindingDirection = SymbolEqualityComparer.Default.Equals(bindingAttrData.AttributeClass?.BaseType, Compilation.GetTypeByMetadataName(Constants.Types.OutputBindingAttribute)) ? "Out" : "In";
 
                 var bindingCount = attributeProperties!.Count + 3;
                 bindings = new Dictionary<string, object>(capacity: bindingCount)
@@ -474,7 +474,7 @@ private bool TryGetAttributeProperties(AttributeData attributeData, Location? at
                 // some properties have default values, so if these properties were not already defined in constructor or named arguments, we will auto-add them here
                 foreach (var member in attributeData.AttributeClass!.GetMembers().Where(a => a is IPropertySymbol))
                 {
-                    var defaultValAttrList = member.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValueType)));
+                    var defaultValAttrList = member.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValue)));
 
                     if (defaultValAttrList.SingleOrDefault() is { } defaultValAttr) // list will only be of size one b/c there cannot be duplicates of an attribute on one piece of syntax
                     {
@@ -546,7 +546,7 @@ private bool TryLoadConstructorArguments(AttributeData attributeData, IDictionar
 
             private void OverrideBindingName(INamedTypeSymbol attributeClass, ref string argumentName)
             {
-                var bindingPropertyNameSymbol = Compilation.GetTypeByMetadataName(Constants.Types.BindingPropertyNameAttributeType);
+                var bindingPropertyNameSymbol = Compilation.GetTypeByMetadataName(Constants.Types.BindingPropertyNameAttribute);
 
                 foreach (var prop in attributeClass.GetMembers().Where(a => a is IPropertySymbol))
                 {
@@ -591,7 +591,7 @@ private bool IsEventHubsTriggerValid(IParameterSymbol parameterSymbol, TypeSynta
                 // Check the default value of IsBatched
                 var eventHubsAttr = attribute.AttributeClass;
                 var isBatchedProp = eventHubsAttr!.GetMembers().Where(m => string.Equals(m.Name, Constants.FunctionMetadataBindingProps.IsBatchedKey, StringComparison.OrdinalIgnoreCase)).SingleOrDefault();
-                AttributeData defaultValAttr = isBatchedProp.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValueType))).SingleOrDefault();
+                AttributeData defaultValAttr = isBatchedProp.GetAttributes().Where(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, Compilation.GetTypeByMetadataName(Constants.Types.DefaultValue))).SingleOrDefault();
                 var defaultVal = defaultValAttr.ConstructorArguments.SingleOrDefault().Value!.ToString(); // there is only one constructor arg, the default value
                 if (!bool.TryParse(defaultVal, out bool b) || !b)
                 {
@@ -602,20 +602,20 @@ private bool IsEventHubsTriggerValid(IParameterSymbol parameterSymbol, TypeSynta
 
                 // we check if the param is an array type
                 // we exclude byte arrays (byte[]) b/c we handle that as cardinality one (we handle this simliar to how a char[] is basically a string)
-                if (parameterSymbol.Type is IArrayTypeSymbol && !SymbolEqualityComparer.Default.Equals(parameterSymbol.Type, Compilation.GetTypeByMetadataName(Constants.Types.ByteArrayType)))
+                if (parameterSymbol.Type is IArrayTypeSymbol && !SymbolEqualityComparer.Default.Equals(parameterSymbol.Type, Compilation.GetTypeByMetadataName(Constants.Types.ByteArray)))
                 {
                     dataType = GetDataType(parameterSymbol.Type);
                     cardinality = Cardinality.Many;
                     return true;
                 }
 
-                var isGenericEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType));
-                var isEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableType));
+                var isGenericEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGeneric));
+                var isEnumerable = parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerable));
 
                 // Check if mapping type - mapping enumerables are not valid types for EventHubParameters
                 if (parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableOfKeyValuePair))
-                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.LookupGenericType))
-                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.DictionaryGenericType)))
+                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.LookupGeneric))
+                    || parameterSymbol.Type.IsOrImplementsOrDerivesFrom(Compilation.GetTypeByMetadataName(Constants.Types.DictionaryGeneric)))
                 {
                     return false;
                 }
@@ -671,13 +671,13 @@ private DataType ResolveIEnumerableOfT(IParameterSymbol parameterSymbol, TypeSyn
                 {
                     INamedTypeSymbol? genericInterfaceSymbol = null;
 
-                    if (currSymbol.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType)) && currSymbol is INamedTypeSymbol currNamedSymbol)
+                    if (currSymbol.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGeneric)) && currSymbol is INamedTypeSymbol currNamedSymbol)
                     {
                         finalSymbol = currNamedSymbol;
                         break;
                     }
 
-                    genericInterfaceSymbol = currSymbol.Interfaces.Where(i => i.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGenericType))).FirstOrDefault();
+                    genericInterfaceSymbol = currSymbol.Interfaces.Where(i => i.IsOrDerivedFrom(Compilation.GetTypeByMetadataName(Constants.Types.IEnumerableGeneric))).FirstOrDefault();
                     if (genericInterfaceSymbol != null)
                     {
                         finalSymbol = genericInterfaceSymbol;
@@ -721,17 +721,17 @@ private DataType GetDataType(ITypeSymbol symbol)
 
             private bool IsStringType(ITypeSymbol symbol)
             {
-                return SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.StringType))
-                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.StringType)));
+                return SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.String))
+                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.String)));
             }
 
             private bool IsBinaryType(ITypeSymbol symbol)
             {
-                var isByteArray = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.ByteArrayType))
-                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStructType)));
+                var isByteArray = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.ByteArray))
+                    || (symbol is IArrayTypeSymbol arraySymbol && SymbolEqualityComparer.Default.Equals(arraySymbol.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStruct)));
                 var isReadOnlyMemoryOfBytes = SymbolEqualityComparer.Default.Equals(symbol, Compilation.GetTypeByMetadataName(Constants.Types.ReadOnlyMemoryOfBytes));
                 var isArrayOfByteArrays = symbol is IArrayTypeSymbol outerArray && 
-                    outerArray.ElementType is IArrayTypeSymbol innerArray && SymbolEqualityComparer.Default.Equals(innerArray.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStructType));
+                    outerArray.ElementType is IArrayTypeSymbol innerArray && SymbolEqualityComparer.Default.Equals(innerArray.ElementType, Compilation.GetTypeByMetadataName(Constants.Types.ByteStruct));
 
 
                 return isByteArray || isReadOnlyMemoryOfBytes || isArrayOfByteArrays;

From f8031f982429ae9726cf6ec1e745a26f02881b92 Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Mon, 9 Jan 2023 15:59:07 -0800
Subject: [PATCH 08/10] fix tests, resolve comments

---
 .../FunctionMetadataProviderGenerator.cs               |  8 ++++----
 test/Sdk.Generator.Tests/TestHelpers.cs                | 10 +++++++---
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
index e6afc5d65..70365a316 100644
--- a/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
+++ b/sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs
@@ -24,9 +24,6 @@ public void Execute(GeneratorExecutionContext context)
                 return;
             }
 
-            // attempt to parse user compilation
-            var p = new Parser(context);
-
             context.AnalyzerConfigOptions.GlobalOptions.TryGetValue(Constants.BuildProperties.EnableSourceGenProp, out var sourceGenSwitch);
 
             bool.TryParse(sourceGenSwitch, out bool enableSourceGen);
@@ -36,6 +33,9 @@ public void Execute(GeneratorExecutionContext context)
                 return;
             }
 
+            // attempt to parse user compilation
+            var p = new Parser(context);
+
             IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
 
             // Proceed to generate the file if function metadata info was successfully returned
@@ -44,7 +44,7 @@ public void Execute(GeneratorExecutionContext context)
                 Emitter e = new();
                 string result = e.Emit(functionMetadataInfo, context.CancellationToken);
 
-                context.AddSource(Constants.FileNames.GeneratedFunctionMetadataFileName, SourceText.From(result, Encoding.UTF8));
+                context.AddSource(Constants.FileNames.GeneratedFunctionMetadata, SourceText.From(result, Encoding.UTF8));
             }
         }
 
diff --git a/test/Sdk.Generator.Tests/TestHelpers.cs b/test/Sdk.Generator.Tests/TestHelpers.cs
index 1666a983d..2d62e2669 100644
--- a/test/Sdk.Generator.Tests/TestHelpers.cs
+++ b/test/Sdk.Generator.Tests/TestHelpers.cs
@@ -34,9 +34,9 @@ public static Task RunTestAsync<TSourceGenerator>(
                     Sources = { inputSource },
                     AdditionalReferences =
                     {
-                        typeof(WorkerExtensionStartupAttribute).Assembly,
-                    },
-                },
+                        typeof(WorkerExtensionStartupAttribute).Assembly
+                    }
+                }
             };
 
             if (expectedOutputSource != null && expectedFileName != null)
@@ -44,6 +44,10 @@ public static Task RunTestAsync<TSourceGenerator>(
                 test.TestState.GeneratedSources.Add((typeof(TSourceGenerator), expectedFileName, SourceText.From(expectedOutputSource, Encoding.UTF8)));
             }
 
+            // Enable SourceGen MSBuild Property for testing
+            string config = $"is_global = true{Environment.NewLine}build_property.FunctionsMetadataSourceGen_Enabled = {true}";
+            test.TestState.AnalyzerConfigFiles.Add(("/.globalconfig", config));
+
             foreach (var item in extensionAssemblyReferences)
             {
                 test.TestState.AdditionalReferences.Add(item);

From ade495937dc5179da79ff753b15c47a03634a5d9 Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Mon, 9 Jan 2023 16:12:49 -0800
Subject: [PATCH 09/10] add to release notes

---
 sdk/release_notes.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sdk/release_notes.md b/sdk/release_notes.md
index c14113d73..e01360db6 100644
--- a/sdk/release_notes.md
+++ b/sdk/release_notes.md
@@ -4,3 +4,5 @@
 -->
 
 - Support sdk-type binding reference type (#1107)
+- Add MS Build property to disable source generation of function metadata (it is enabled automatically) (#1200)
+  - Prop name: "FunctionsMetadataSourceGen_Enabled"
\ No newline at end of file

From 9f40b308116b41247dd43208b9315464bf682afb Mon Sep 17 00:00:00 2001
From: Sarah Vu <sarahvu@microsoft.com>
Date: Mon, 9 Jan 2023 16:14:21 -0800
Subject: [PATCH 10/10] typo fix

---
 sdk/release_notes.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sdk/release_notes.md b/sdk/release_notes.md
index e01360db6..641849aa8 100644
--- a/sdk/release_notes.md
+++ b/sdk/release_notes.md
@@ -5,4 +5,4 @@
 
 - Support sdk-type binding reference type (#1107)
 - Add MS Build property to disable source generation of function metadata (it is enabled automatically) (#1200)
-  - Prop name: "FunctionsMetadataSourceGen_Enabled"
\ No newline at end of file
+  - Prop name: `FunctionsMetadataSourceGen_Enabled`
\ No newline at end of file