Skip to content

Conversation

@satvu
Copy link
Member

@satvu satvu commented Nov 28, 2022

Issue describing the changes in this PR

resolves #1155

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Using guidance from this section of the generators cookbook.

For manual testing, I recommend creating a local nuget package of the SDK and referencing that in a simple app (like http trigger template app).

@satvu satvu changed the title initial wip Add MSBuild prop to disable source-generated function metadata Nov 28, 2022
@satvu satvu requested review from fabiocav, jviau and kshyju and removed request for kshyju November 28, 2022 20:53
@satvu satvu changed the title Add MSBuild prop to disable source-generated function metadata [SourceGen] Add MSBuild prop to disable source-generated function metadata Nov 28, 2022
@satvu satvu force-pushed the satvu/source-gen-msbuild-switch branch from 17b0fbe to 5b6022d Compare December 1, 2022 21:33
@satvu satvu marked this pull request as ready for review December 1, 2022 21:35
@satvu satvu force-pushed the satvu/source-gen-msbuild-switch branch from ed90014 to 4e5997a Compare December 14, 2022 21:05
@ghost
Copy link

ghost commented Dec 21, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@jviau
Copy link
Contributor

jviau commented Dec 21, 2022

bump to avoid closure.

Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💰

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is enabled by default. If user do not want source gen version, they have to explicitly set this prop to false in their csproj?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - the current behavior is that the generation of the file happens automatically so I followed that and added this prop to disable it. Pros and cons for either default - mostly depends on how we want this rolled out and how we want customers to opt-in (more steps, less steps?).

@satvu satvu force-pushed the satvu/source-gen-msbuild-switch branch from b00f8f6 to f8031f9 Compare January 10, 2023 00:10
@satvu
Copy link
Member Author

satvu commented Jan 10, 2023

/check-enforcer evaluate

@satvu satvu merged commit ae0cbe0 into main Jan 10, 2023
@satvu satvu deleted the satvu/source-gen-msbuild-switch branch January 10, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MSBuild Property to disable/enable function metadata source generator

5 participants