-
Notifications
You must be signed in to change notification settings - Fork 201
[SourceGen] Add MSBuild prop to disable source-generated function metadata #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17b0fbe to
5b6022d
Compare
ed90014 to
4e5997a
Compare
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
|
bump to avoid closure. |
kshyju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is enabled by default. If user do not want source gen version, they have to explicitly set this prop to false in their csproj?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - the current behavior is that the generation of the file happens automatically so I followed that and added this prop to disable it. Pros and cons for either default - mostly depends on how we want this rolled out and how we want customers to opt-in (more steps, less steps?).
b00f8f6 to
f8031f9
Compare
|
/check-enforcer evaluate |
Issue describing the changes in this PR
resolves #1155
Pull request checklist
release_notes.mdAdditional information
Using guidance from this section of the generators cookbook.
For manual testing, I recommend creating a local nuget package of the SDK and referencing that in a simple app (like http trigger template app).