Skip to content

New overloads for WriteStringAsync and WriteBytesAsync method which takes CancellationToken #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2022
Merged

New overloads for WriteStringAsync and WriteBytesAsync method which takes CancellationToken #1111

merged 3 commits into from
Oct 12, 2022

Conversation

@kshyju
Copy link
Member

@kshyju kshyju commented Oct 7, 2022 •
edited
Loading

Fixes #1078

Exposing 2 new overloads which internally calls the Stream.WriteAsync overload which takes a CancellationToken instance

public static Task WriteBytesAsync(this HttpResponseData response, byte[] value, CancellationToken cancellationToken)
public static Task WriteStringAsync(this HttpResponseData response, string value, 
                                                    CancellationToken cancellationToken, Encoding? encoding = null)

Not bumping up package version as I think we can club this change with other ones.

kshyju
kshyju commented Oct 7, 2022
View reviewed changes
src/DotNetWorker.Core/Http/HttpResponseDataExtensions.cs Outdated
Copy link
Member Author

@kshyju kshyju Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new overload we are exposing.

kshyju
kshyju commented Oct 7, 2022
View reviewed changes
src/DotNetWorker.Core/Http/HttpResponseDataExtensions.cs Outdated
Copy link
Member Author

@kshyju kshyju Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other new overload we are exposing.

satvu
satvu reviewed Oct 7, 2022
View reviewed changes
src/DotNetWorker.Core/Http/HttpResponseDataExtensions.cs Outdated
Copy link
Member

@satvu satvu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

satvu
satvu reviewed Oct 7, 2022
View reviewed changes
src/DotNetWorker.Core/Http/HttpResponseDataExtensions.cs Outdated
Copy link
Member

@satvu satvu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still grammatically correct, but if you want to match the other summaries this is missing an 's' (writes not write).

Copy link
Member Author

@kshyju kshyju Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye 🔍. Fixed.

@kshyju kshyju force-pushed the shkr/gh1078_writeasync_with_cancellation_token branch from 508f694 to f6b0d64 Compare October 12, 2022 15:09
@kshyju
Copy link
Member Author

kshyju commented Oct 12, 2022

/check-enforcer evaluate

@kshyju
Copy link
Member Author

kshyju commented Oct 12, 2022

/check-enforcer reset

@kshyju kshyju merged commit 853fc0a into main Oct 12, 2022
@kshyju kshyju deleted the shkr/gh1078_writeasync_with_cancellation_token branch October 12, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liliankasem liliankasem liliankasem approved these changes

@satvu satvu satvu approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

@brettsam brettsam Awaiting requested review from brettsam

+1 more reviewer

@madelinegordon madelinegordon madelinegordon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose new overloads for WriteStringAsync and WriteBytesAsync extension methods

5 participants

@kshyju @liliankasem @satvu @madelinegordon