fix tests, resolve comments

Author: satvu

sdk/Sdk.Generators/FunctionMetadataProviderGenerator.cs

@@ -24,9 +24,6 @@ public void Execute(GeneratorExecutionContext context)
                 return;
             }
 
-            // attempt to parse user compilation
-            var p = new Parser(context);
-
             context.AnalyzerConfigOptions.GlobalOptions.TryGetValue(Constants.BuildProperties.EnableSourceGenProp, out var sourceGenSwitch);
 
             bool.TryParse(sourceGenSwitch, out bool enableSourceGen);
@@ -36,6 +33,9 @@ public void Execute(GeneratorExecutionContext context)
                 return;
             }
 
+            // attempt to parse user compilation
+            var p = new Parser(context);
+
             IReadOnlyList<GeneratorFunctionMetadata> functionMetadataInfo = p.GetFunctionMetadataInfo(receiver.CandidateMethods);
 
             // Proceed to generate the file if function metadata info was successfully returned
@@ -44,7 +44,7 @@ public void Execute(GeneratorExecutionContext context)
                 Emitter e = new();
                 string result = e.Emit(functionMetadataInfo, context.CancellationToken);
 
-                context.AddSource(Constants.FileNames.GeneratedFunctionMetadataFileName, SourceText.From(result, Encoding.UTF8));
+                context.AddSource(Constants.FileNames.GeneratedFunctionMetadata, SourceText.From(result, Encoding.UTF8));
             }
         }
 

test/Sdk.Generator.Tests/TestHelpers.cs

@@ -34,16 +34,20 @@ public static Task RunTestAsync<TSourceGenerator>(
                     Sources = { inputSource },
                     AdditionalReferences =
                     {
-                        typeof(WorkerExtensionStartupAttribute).Assembly,
-                    },
-                },
+                        typeof(WorkerExtensionStartupAttribute).Assembly
+                    }
+                }
             };
 
             if (expectedOutputSource != null && expectedFileName != null)
             {
                 test.TestState.GeneratedSources.Add((typeof(TSourceGenerator), expectedFileName, SourceText.From(expectedOutputSource, Encoding.UTF8)));
             }
 
+            // Enable SourceGen MSBuild Property for testing
+            string config = $"is_global = true{Environment.NewLine}build_property.FunctionsMetadataSourceGen_Enabled = {true}";
+            test.TestState.AnalyzerConfigFiles.Add(("/.globalconfig", config));
+
             foreach (var item in extensionAssemblyReferences)
             {
                 test.TestState.AdditionalReferences.Add(item);