PR Feedback

Author: fabiocav

src/DotNetWorker.Grpc/Definition/GrpcFunctionDefinition.cs

@@ -21,7 +21,7 @@ public GrpcFunctionDefinition(FunctionLoadRequest loadRequest, IMethodInfoLocato
             Name = loadRequest.Metadata.Name;
             Id = loadRequest.FunctionId;
 
-            string? scriptRoot = Environment.GetEnvironmentVariable("AzureWebJobsScriptRoot")!;
+            string? scriptRoot = Environment.GetEnvironmentVariable("AzureWebJobsScriptRoot");
             if (string.IsNullOrWhiteSpace(scriptRoot))
             {
                 throw new ArgumentException("AzureWebJobsScriptRoot env variable value is null or empty");

src/DotNetWorker.Grpc/DotNetWorker.Grpc.csproj

@@ -40,7 +40,7 @@
     Grpc.Net.Client implementation-->
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
     <PackageReference Include="Grpc.Core" Version="2.45.0" />
-    <Compile Remove="NativeHostIntegration/./*.*" />
+    <Compile Remove="NativeHostIntegration/**" />
   </ItemGroup>
 
   <ItemGroup>

src/DotNetWorker.Grpc/GrpcServiceCollectionExtensions.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Threading.Channels;
-using Microsoft.Azure.Functions.Core;
 using Microsoft.Azure.Functions.Worker;
 using Microsoft.Azure.Functions.Worker.Core.FunctionMetadata;
 using Microsoft.Azure.Functions.Worker.Grpc.Messages;

src/DotNetWorker.Grpc/GrpcWorker.cs

@@ -5,10 +5,8 @@
 using System.Linq;
 using System.Runtime.InteropServices;
 using System.Threading;
-using System.Threading.Channels;
 using System.Threading.Tasks;
 using Azure.Core.Serialization;
-using Grpc.Core;
 using Microsoft.Azure.Functions.Worker.Context.Features;
 using Microsoft.Azure.Functions.Worker.Core.FunctionMetadata;
 using Microsoft.Azure.Functions.Worker.Grpc;
@@ -21,7 +19,6 @@
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
-using static Microsoft.Azure.Functions.Worker.Grpc.Messages.FunctionRpc;
 using MsgType = Microsoft.Azure.Functions.Worker.Grpc.Messages.StreamingMessage.ContentOneofCase;
 
 namespace Microsoft.Azure.Functions.Worker
@@ -78,7 +75,7 @@ public async Task StartAsync(CancellationToken token)
         Task IMessageProcessor.ProcessMessageAsync(StreamingMessage message)
         {
             // Dispatch and return.
-            Task.Run(() => ProcessRequestCoreAsync(message));
+            _ = ProcessRequestCoreAsync(message);
 
             return Task.CompletedTask;
         }

src/DotNetWorker.Grpc/GrpcWorkerClientFactory.cs

@@ -35,7 +35,6 @@ public Task<IWorkerClient> StartClientAsync(IMessageProcessor messageProcessor,
         private class GrpcWorkerClient : IWorkerClient
         {
             private readonly FunctionRpcClient _grpcClient;
-            private readonly GrpcHostChannel _outputChannel;
             private readonly GrpcWorkerStartupOptions _startupOptions;
             private readonly ChannelReader<StreamingMessage> _outputReader;
             private readonly ChannelWriter<StreamingMessage> _outputWriter;
@@ -44,7 +43,6 @@ private class GrpcWorkerClient : IWorkerClient
 
             public GrpcWorkerClient(GrpcHostChannel outputChannel, GrpcWorkerStartupOptions startupOptions)
             {
-                _outputChannel = outputChannel ?? throw new ArgumentNullException(nameof(outputChannel));
                 _startupOptions = startupOptions ?? throw new ArgumentNullException(nameof(startupOptions));
 
                 _outputReader = outputChannel.Channel.Reader;

src/DotNetWorker.Grpc/NativeHostIntegration/NativeMethods.cs

@@ -10,7 +10,7 @@ namespace Microsoft.Azure.Functions.Worker.Grpc.NativeHostIntegration
 {
     internal static unsafe partial class NativeMethods
     {
-        internal const string NativeWorkerDll = "FunctionsNetHost.exe";
+        private const string NativeWorkerDll = "FunctionsNetHost.exe";
 
         public static NativeHost GetNativeHostData()
         {