-
Notifications
You must be signed in to change notification settings - Fork 524
[Internal] ContainerProperties: Adds Full Text Search and Indexing Policy #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] ContainerProperties: Adds Full Text Search and Indexing Policy #4837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Show resolved
Hide resolved
Pilchie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would like to see tests actually run, and an additional test case.
Microsoft.Azure.Cosmos/src/Fluent/Settings/FullTextIndexDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Fluent/ContainerSettingsTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| /// <inheritdoc/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to override GetHashCode()?
Pull Request Template
Description
This PR adds a new
FullTextPolicyinContainerPropertiesand a newFullTextIndexesin theIndexingPolicyto enable Full Text Search in Cosmos DB.Below is a sample for the new
ContainerPropertieswith Full Text Indexing Policy andFull Text Policy highlighted.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4820