lint

Author: gossion

internal/auth/oauth/endpoints.go

@@ -296,7 +296,9 @@ func (em *EndpointManager) tokenIntrospectionHandler() http.HandlerFunc {
 			}
 
 			w.Header().Set("Content-Type", "application/json")
-			json.NewEncoder(w).Encode(response)
+			if err := json.NewEncoder(w).Encode(response); err != nil {
+				log.Printf("Failed to encode introspection response: %v", err)
+			}
 			return
 		}
 
@@ -419,7 +421,9 @@ func (em *EndpointManager) writeErrorResponse(w http.ResponseWriter, errorCode,
 		"error_description": description,
 	}
 
-	json.NewEncoder(w).Encode(response)
+	if err := json.NewEncoder(w).Encode(response); err != nil {
+		log.Printf("Failed to encode error response: %v", err)
+	}
 }
 
 // authorizationProxyHandler proxies authorization requests to Azure AD with resource parameter filtering
@@ -608,7 +612,11 @@ func (em *EndpointManager) exchangeCodeForToken(code, state string) (*TokenRespo
 	if err != nil {
 		return nil, fmt.Errorf("token exchange request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			log.Printf("Failed to close response body: %v", err)
+		}
+	}()
 
 	if resp.StatusCode != http.StatusOK {
 		body, _ := io.ReadAll(resp.Body)
@@ -649,7 +657,9 @@ func (em *EndpointManager) writeCallbackErrorResponse(w http.ResponseWriter, mes
 </body>
 </html>`, message)
 
-	w.Write([]byte(html))
+	if _, err := w.Write([]byte(html)); err != nil {
+		log.Printf("Failed to write error response: %v", err)
+	}
 }
 
 // writeCallbackSuccessResponse writes a success response for callback
@@ -733,7 +743,9 @@ func (em *EndpointManager) writeCallbackSuccessResponse(w http.ResponseWriter, t
 		tokenResponse.AccessToken,
 		tokenResponse.AccessToken)
 
-	w.Write([]byte(html))
+	if _, err := w.Write([]byte(html)); err != nil {
+		log.Printf("Failed to write success response: %v", err)
+	}
 }
 
 // isValidClientID validates if a client ID is acceptable
@@ -896,7 +908,11 @@ func (em *EndpointManager) exchangeCodeForTokenDirect(code, redirectURI, codeVer
 	if err != nil {
 		return nil, fmt.Errorf("token exchange request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			log.Printf("Failed to close response body: %v", err)
+		}
+	}()
 
 	if resp.StatusCode != http.StatusOK {
 		body, _ := io.ReadAll(resp.Body)

internal/auth/oauth/middleware_test.go

@@ -44,7 +44,9 @@ func TestAuthMiddleware(t *testing.T) {
 	// Create a test handler
 	testHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("success"))
+		if _, err := w.Write([]byte("success")); err != nil {
+			t.Errorf("Failed to write test response: %v", err)
+		}
 	})
 
 	wrappedHandler := middleware.Middleware(testHandler)

internal/auth/oauth/provider.go

@@ -116,7 +116,11 @@ func (p *AzureOAuthProvider) GetAuthorizationServerMetadata(serverURL string) (*
 		log.Printf("OAuth ERROR: Failed to fetch metadata from %s: %v", metadataURL, err)
 		return nil, fmt.Errorf("failed to fetch metadata from %s: %w", metadataURL, err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			log.Printf("Failed to close response body: %v", err)
+		}
+	}()
 
 	if resp.StatusCode == http.StatusNotFound {
 		log.Printf("OAuth ERROR: Tenant ID '%s' not found (HTTP 404)", p.config.TenantID)
@@ -421,7 +425,11 @@ func (p *AzureOAuthProvider) getPublicKey(kid string, issuer string) (*rsa.Publi
 	if err != nil {
 		return nil, fmt.Errorf("failed to fetch JWKS from %s: %w", jwksURL, err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if err := resp.Body.Close(); err != nil {
+			log.Printf("Failed to close response body: %v", err)
+		}
+	}()
 
 	if resp.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("JWKS endpoint returned status %d", resp.StatusCode)

internal/auth/oauth/provider_test.go

@@ -113,7 +113,9 @@ func TestGetAuthorizationServerMetadataWithDefaults(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(mockMetadata)
+		if err := json.NewEncoder(w).Encode(mockMetadata); err != nil {
+			http.Error(w, "Failed to encode response", http.StatusInternalServerError)
+		}
 	}))
 	defer server.Close()
 
@@ -211,7 +213,9 @@ func TestGetAuthorizationServerMetadata(t *testing.T) {
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(mockMetadata)
+		if err := json.NewEncoder(w).Encode(mockMetadata); err != nil {
+			http.Error(w, "Failed to encode response", http.StatusInternalServerError)
+		}
 	}))
 	defer server.Close()