L3 performance and scaling enhancements HLD initial version#399
Merged
xinliu-seattle merged 1 commit intosonic-net:masterfrom Nov 6, 2019
Merged
L3 performance and scaling enhancements HLD initial version#399xinliu-seattle merged 1 commit intosonic-net:masterfrom
xinliu-seattle merged 1 commit intosonic-net:masterfrom
Conversation
|
|
lguohan
reviewed
Jul 2, 2019
madhupalu
reviewed
Jul 2, 2019
| | 10k IPv4 prefix routes | 11 seconds | | ||
| | 30k IPv4 prefix routes | 30 seconds | | ||
| | 60k IPv4 prefix routes | 48 seconds | | ||
| | 90k IPv4 prefix routes | 68 seconds | |
Contributor
There was a problem hiding this comment.
Do you have breakdown of programming time of each layer ex: orchagent or fpmsyncd/syncd?
| | Routes | time taken on AS7712(Tomahawk) | | ||
| | ---------------------------------- | ----------------------------- | | ||
| | 10k IPv6 route with prefixes > 64b | 11 seconds | | ||
| | 30k IPv6 route with prefixes >64b | 30 seconds | |
Contributor
There was a problem hiding this comment.
please list out all the usecases will need perf enhancements?
Ex: 1) Sonic boot time 2) graceful restart 3) download routes etc.
|
|
||
| Bulking of Route updates will be enabled in Orchagent. Orchagent will bulk 64 updates and send to Sairedis. | ||
| A new timer will be introduced in orchagent to flush the outstanding updates every second. | ||
|
|
Contributor
There was a problem hiding this comment.
Bulking idea is nice but It introduces the delay for non bulk cases too. Can this timer tuned(starts off with low value and grow exponenetially, simiar to tcp)?
| | 4. | Clear neigh table and check all routes and forwarding | | | | ||
| | 5. | Clear mac table and check all routes and forwarding | | | | ||
| | 6. | Test across warm reboot , Orchagt/Syncd restart and upgrade | | | | ||
|
|
Contributor
There was a problem hiding this comment.
Add these tests with warm reboot/graceful restart?
stcheng
reviewed
Jul 3, 2019
|
|
||
| So, the saving achieved by using bulk APIs will be number of Redis message generated. | ||
|
|
||
| Bulking of Route updates will be enabled in Orchagent. Orchagent will bulk 64 updates and send to Sairedis. |
Contributor
There was a problem hiding this comment.
any reason why the bulk size is 64?
qiluo-msft
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L3 performance and scaling enhancements HLD initial version