Add integration testing (#634)

* add initial integration test file

* update auth

* add skipping

* organize tests into unit and integration

* update formatting

* WIP create config store

* edit

* update integration setup

* copilot updates

* initial working version of integration tests

* remove obsolete tags and update formatting

* updating tests

* format

* remove skipping, add tests

* add cleanup stale resource call on startup and dispose

* add back removed line

* use persistent resource group

* add ordering of apis test

* add refresh test

* add tests

* add failover test

* adding snapshot tests first draft

* fix snapshot tests

* add key vault tests

* add more keyvault tests

* fix keyvault tests

* add cleanup of key values/secrets/snapshot

* fix key vault isolation

* remove base exception catches

* update ci.yml to work with integration tests and use github repo secrets

* add id token write permission

* update ci.yml step to create subscription file

* edit ci.yml

* fix github action

* update comment in powershell script

* remove unused packages

* update comment, remove unused methods

* add request tracing test

* check for status code in catch, move cleanupstaleresources call to dispose

* PR comments

* comments

* comments

* update copilot instructions

* update copilot instructions

* fix try blocks to only surround throwing code

* fix setuptestkeys, simplify comments and setup code

* tagfilters integration test in progress

* tagfilters integration test in progress

* correct api version

* fixed tagfilter test

* fix requesttracing test

* allow commas in json reader

* stale threshold

* remove copilot instructions

* use outputhelper

* fix cleanupstale

* update setup method, remove flag

Author: amerjusupovic

.github/workflows/ci.yml

@@ -14,6 +14,7 @@ on:
 
 permissions:
   security-events: write
+  id-token: write
 
 jobs:
   build:
@@ -40,8 +41,17 @@ jobs:
       - name: Dotnet Pack
         run: pwsh pack.ps1
 
+      - name: Azure Login with OIDC
+        uses: azure/login@v1
+        with:
+          client-id: ${{ secrets.AZURE_CLIENT_ID }}
+          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
+
       - name: Dotnet Test
         run: pwsh test.ps1
+        env:
+          AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
       - name: Publish Test Results
         uses: actions/upload-artifact@v4

.gitignore

@@ -6,6 +6,9 @@
 # Azure Functions localsettings file
 local.settings.json
 
+# Integration test secrets
+appsettings.Secrets.json
+
 # User-specific files
 *.suo
 *.user

src/Microsoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureManagementKeyValueAdapter.cs

@@ -426,7 +426,12 @@ private FeatureFlag ParseFeatureFlag(string settingKey, string settingValue)
         {
             var featureFlag = new FeatureFlag();
 
-            var reader = new Utf8JsonReader(System.Text.Encoding.UTF8.GetBytes(settingValue));
+            var reader = new Utf8JsonReader(
+                System.Text.Encoding.UTF8.GetBytes(settingValue),
+                new JsonReaderOptions
+                {
+                    AllowTrailingCommas = true
+                });
 
             try
             {

tests/Tests.AzureAppConfiguration/Integration/GetAzureSubscription.ps1

@@ -0,0 +1,47 @@
+#!/usr/bin/env pwsh
+
+# GetAzureSubscription.ps1
+# This script gets the AppConfig - Dev subscription ID and saves it to a JSON file
+
+$outputPath = Join-Path $PSScriptRoot "appsettings.Secrets.json"
+
+Write-Host "Checking for active Azure CLI login"
+
+az account show | Out-Null
+
+if ($LASTEXITCODE -ne 0) {
+    Write-Host "Must be logged in with the Azure CLI to proceed"
+
+    az login
+
+    if ($LASTEXITCODE -ne 0) {
+        Write-Host "Azure login failed"
+        return
+    }
+}
+
+az account set --name "AppConfig - Dev"
+
+# Get current subscription from az CLI
+$subscriptionId = az account show --query id -o tsv 2>&1
+
+if ($LASTEXITCODE -ne 0) {
+    Write-Host "Azure CLI command failed with exit code $LASTEXITCODE. Output: $subscriptionId"
+    return
+}
+
+# Check if the output is empty
+if ([string]::IsNullOrWhiteSpace($subscriptionId)) {
+    Write-Host "No active Azure subscription found. Please run 'az login' first."
+
+    exit 1
+}
+
+# If successful, save the subscription ID to a JSON file
+$result = @{
+    SubscriptionId = $subscriptionId.Trim()
+}
+    
+$result | ConvertTo-Json | Out-File $outputPath -Encoding utf8
+Write-Host "Subscription information saved to: $outputPath"
+exit 0