fix(build): remove invalid double cast on JaCoCo counter array#312
Merged
WilliamBerryiii merged 1 commit intomainfrom Feb 18, 2026
Merged
fix(build): remove invalid double cast on JaCoCo counter array#312WilliamBerryiii merged 1 commit intomainfrom
WilliamBerryiii merged 1 commit intomainfrom
Conversation
…threshold check - JaCoCo XML report contains multiple counter elements (LINE, BRANCH, etc.) - [double] cast applied to System.Object[] before pipeline filters to LINE - remove premature cast; ForEach-Object already returns numeric via [math]::Round 🐛 - Generated by Copilot
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
agreaves-ms
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed a
[double]cast that was applied to the entire$coverage.report.counterarray before the pipeline could filter it to theLINEcounter type. JaCoCo XML reports contain multiple<counter>elements (LINE, BRANCH, etc.), so the cast onSystem.Object[]raised a conversion error and broke the Coverage Threshold Check step on every CI run.[double]cast from the$coverage.report.counterpipeline expression in the Coverage Threshold Check step of the Pester Tests workflowType of Change
Component(s) Affected
deploy/000-prerequisites- Azure subscription setupdeploy/001-iac- Terraform infrastructuredeploy/002-setup- OSMO control plane / Helmdeploy/004-workflow- Training workflowssrc/training- Python training scriptsdocs/- DocumentationTesting Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Documentation Impact
Checklist