Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

Commit 5a82581

Browse files
refactor(src): standardize os.environ usage in inference upload script (#194)
- add set_env_defaults import from training.utils in main() - centralize default values for 8 environment variables - replace os.environ.get with os.environ[] for defaulted vars - keep os.environ.get for optional and dependent vars 🔧 - Generated by Copilot
1 parent e6c1730 commit 5a82581

1 file changed

Lines changed: 21 additions & 8 deletions

File tree

src/inference/scripts/upload_artifacts.py

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ def upload_to_mlflow(
9090
)
9191
mlflow.log_params(
9292
{
93-
"num_envs": os.environ.get("NUM_ENVS", "4"),
94-
"max_steps": os.environ.get("MAX_STEPS", "500"),
95-
"video_length": os.environ.get("VIDEO_LENGTH", "200"),
96-
"inference_format": os.environ.get("INFERENCE_FORMAT", "both"),
93+
"num_envs": os.environ["NUM_ENVS"],
94+
"max_steps": os.environ["MAX_STEPS"],
95+
"video_length": os.environ["VIDEO_LENGTH"],
96+
"inference_format": os.environ["INFERENCE_FORMAT"],
9797
}
9898
)
9999

@@ -267,14 +267,27 @@ def main() -> None:
267267
if src_root and src_root not in sys.path:
268268
sys.path.insert(0, src_root)
269269

270-
task = os.environ.get("TASK", "unknown")
271-
export_dir = Path(os.environ.get("EXPORT_DIR", "/tmp/exported"))
270+
from training.utils import set_env_defaults
271+
272+
set_env_defaults({
273+
"TASK": "unknown",
274+
"EXPORT_DIR": "/tmp/exported",
275+
"ONNX_SUCCESS": "0",
276+
"JIT_SUCCESS": "0",
277+
"NUM_ENVS": "4",
278+
"MAX_STEPS": "500",
279+
"VIDEO_LENGTH": "200",
280+
"INFERENCE_FORMAT": "both",
281+
})
282+
283+
task = os.environ["TASK"]
284+
export_dir = Path(os.environ["EXPORT_DIR"])
272285
metrics_dir = Path(os.environ.get("METRICS_DIR", str(export_dir / "metrics")))
273286
checkpoint_uri = os.environ.get("CHECKPOINT_URI", "")
274287
blob_account = os.environ.get("BLOB_STORAGE_ACCOUNT", "")
275288
blob_container = os.environ.get("BLOB_CONTAINER", "")
276-
onnx_success = os.environ.get("ONNX_SUCCESS", "0") == "1"
277-
jit_success = os.environ.get("JIT_SUCCESS", "0") == "1"
289+
onnx_success = os.environ["ONNX_SUCCESS"] == "1"
290+
jit_success = os.environ["JIT_SUCCESS"] == "1"
278291
timestamp = datetime.utcnow().strftime("%Y%m%d_%H%M%S")
279292

280293
onnx_metrics, jit_metrics = load_metrics(metrics_dir)

0 commit comments

Comments
 (0)