feat: IVC bench

[ledwards2225]

Adds benchmark suite for the PG-Goblin client IVC scheme. The only real caveat is that we only consider function circuits of size 2^17 since our PG code doesn't support folding unequal sizes.

Results at present:

-----------------------------------------------------------------
Benchmark                       Time             CPU   Iterations
-----------------------------------------------------------------
IvcBench/Full/6             66891 ms        63569 ms            1

[ledwards2225]

added ivc_bench and alphabetized

[ledwards2225]

Needing to add client_ivc to the goblin module is is again a symptom of having mock_circuits within goblin. There's a good bit of related restructuring to do here so I'd like to do a follow on to move things around.

[codygunton]

This introduces a circular dependency. Can you just do the reorg now?

[codygunton]

I don't understand why this is needed here. What's defined (not declared, but defined) in client_ivc but needed in goblin?

[codygunton]

Will you please fix the circular linking issue and then merge? Thanks!

[codygunton]

This introduces a circular dependency. Can you just do the reorg now?

[codygunton]

I don't understand why this is needed here. What's defined (not declared, but defined) in client_ivc but needed in goblin?

[AztecBot]

Benchmark results

Metrics with a significant change:

• batch_insert_into_append_only_tree_32_depth_ms (512): 239 (-20%)
• note_history_trial_decrypting_time_in_ms (5): 169 (+94%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit bf4fc6c7 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,712	871,420	3,465,724
l1_rollup_execution_gas	315,903	989,868	3,686,102
l2_block_processing_time_in_ms	1,154 (-6%)	4,372 (-1%)	17,239 (-1%)
note_successful_decrypting_time_in_ms	320	1,030 (+1%)	3,702 (-4%)
note_trial_decrypting_time_in_ms	31.1 (+15%)	44.0	144 (-6%)
l2_block_building_time_in_ms	17,915	70,878	282,891
l2_block_rollup_simulation_time_in_ms	13,172 (+1%)	52,006	208,471
l2_block_public_tx_process_time_in_ms	4,715	18,792 (+1%)	74,149

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,886 (-1%)	26,677 (-3%)
note_history_successful_decrypting_time_in_ms	2,616 (+6%)	4,868 (+4%)
note_history_trial_decrypting_time_in_ms	⚠️ 169 (+94%)	244 (+45%)
node_database_size_in_bytes	17,342,544	33,038,416
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	308 (+1%)	44,528	25,825
private-kernel-ordering	195 (+1%)	44,145	16,225
base-rollup	1,408	128,654	933
root-rollup	82.8	4,192	729
private-kernel-inner	438	71,331	25,825
public-kernel-private-input	242	32,287	25,825
public-kernel-non-first-iteration	237	32,329	25,825
merge-rollup	7.96	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	10.7 (-5%)	12.6 (-8%)	17.1 (-3%)	23.0 (-11%)	64.4 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.595 (-5%)	0.537 (-7%)	0.528 (-3%)	0.479 (-10%)	0.444 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.8 (-2%)	47.7	⚠️ 239 (-20%)	463 (-1%)	903 (-1%)	3,564
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.462 (-2%)	0.489	0.436 (-19%)	0.433 (-1%)	0.429 (-1%)	0.429
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (-1%)	56.9	352 (+1%)	691	1,369	5,411 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.496	0.497	0.475	0.473	0.471 (-1%)	0.470
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.7	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.579	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	40,167

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	554 (-3%)	1,312

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.530 (-5%)	578