test fix

Author: benesjan

yarn-project/end-to-end/src/e2e_2_pxes.test.ts

@@ -249,6 +249,9 @@ describe('e2e_2_pxes', () => {
       note = notes[0];
     }
 
+    // TODO(#12013): We need to do this hack because NoteDao no longer populates noteTypeId
+    note.noteTypeId = TestContract.notes.ValueNote.id;
+
     // 3. Nullify the note
     {
       const receipt = await testContract.methods.call_destroy_note(noteStorageSlot).send().wait({ debug: true });

yarn-project/pxe/src/database/note_dao.ts

@@ -54,7 +54,7 @@ export class NoteDao implements NoteData {
     public addressPoint: PublicKey,
 
     /** The note type identifier for the contract.
-     * TODO: remove
+     * TODO(#12013): remove
      */
     public noteTypeId: NoteSelector,
   ) {}

yarn-project/pxe/src/simulator_oracle/index.ts

@@ -775,7 +775,7 @@ export class SimulatorOracle implements DBOracle {
       receipt.blockHash!.toString(),
       uniqueNoteHashTreeIndex,
       await recipient.toAddressPoint(),
-      NoteSelector.empty(), // todo: remove
+      NoteSelector.empty(), // TODO(#12013): remove
     );
   }