Allow running e2e prover with fake proofs enabled

Author: spalladino

yarn-project/bb-prover/src/index.ts

@@ -3,3 +3,5 @@ export * from './test/index.js';
 export * from './verifier/index.js';
 export * from './config.js';
 export * from './bb/execute.js';
+
+export { type ClientProtocolCircuitVerifier } from '@aztec/circuit-types';

yarn-project/end-to-end/src/e2e_prover/e2e_prover_test.ts

@@ -16,7 +16,7 @@ import {
   createDebugLogger,
   deployL1Contract,
 } from '@aztec/aztec.js';
-import { BBCircuitVerifier } from '@aztec/bb-prover';
+import { BBCircuitVerifier, type ClientProtocolCircuitVerifier, TestCircuitVerifier } from '@aztec/bb-prover';
 import { RollupAbi } from '@aztec/l1-artifacts';
 import { TokenContract } from '@aztec/noir-contracts.js';
 import { type ProverNode, type ProverNodeConfig, createProverNode } from '@aztec/prover-node';
@@ -73,14 +73,14 @@ export class FullProverTest {
   private provenComponents: ProvenSetup[] = [];
   private bbConfigCleanup?: () => Promise<void>;
   private acvmConfigCleanup?: () => Promise<void>;
-  circuitProofVerifier?: BBCircuitVerifier;
+  circuitProofVerifier?: ClientProtocolCircuitVerifier;
   provenAssets: TokenContract[] = [];
   private context!: SubsystemsContext;
   private proverNode!: ProverNode;
   private simulatedProverNode!: ProverNode;
   private l1Contracts!: DeployL1Contracts;
 
-  constructor(testName: string, private minNumberOfTxsPerBlock: number) {
+  constructor(testName: string, private minNumberOfTxsPerBlock: number, private realProofs = true) {
     this.logger = createDebugLogger(`aztec:full_prover_test:${testName}`);
     this.snapshotManager = createSnapshotManager(`full_prover_integration/${testName}`, dataPath);
   }
@@ -149,33 +149,39 @@ export class FullProverTest {
 
     // Configure a full prover PXE
 
-    const [acvmConfig, bbConfig] = await Promise.all([getACVMConfig(this.logger), getBBConfig(this.logger)]);
-    if (!acvmConfig || !bbConfig) {
-      throw new Error('Missing ACVM or BB config');
-    }
+    let acvmConfig: Awaited<ReturnType<typeof getACVMConfig>> | undefined;
+    let bbConfig: Awaited<ReturnType<typeof getBBConfig>> | undefined;
+    if (this.realProofs) {
+      [acvmConfig, bbConfig] = await Promise.all([getACVMConfig(this.logger), getBBConfig(this.logger)]);
+      if (!acvmConfig || !bbConfig) {
+        throw new Error('Missing ACVM or BB config');
+      }
 
-    this.acvmConfigCleanup = acvmConfig.cleanup;
-    this.bbConfigCleanup = bbConfig.cleanup;
+      this.acvmConfigCleanup = acvmConfig.cleanup;
+      this.bbConfigCleanup = bbConfig.cleanup;
 
-    if (!bbConfig?.bbWorkingDirectory || !bbConfig?.bbBinaryPath) {
-      throw new Error(`Test must be run with BB native configuration`);
-    }
+      if (!bbConfig?.bbWorkingDirectory || !bbConfig?.bbBinaryPath) {
+        throw new Error(`Test must be run with BB native configuration`);
+      }
 
-    this.circuitProofVerifier = await BBCircuitVerifier.new(bbConfig);
+      this.circuitProofVerifier = await BBCircuitVerifier.new(bbConfig);
 
-    this.logger.debug(`Configuring the node for real proofs...`);
-    await this.aztecNode.setConfig({
-      realProofs: true,
-      minTxsPerBlock: this.minNumberOfTxsPerBlock,
-    });
+      this.logger.debug(`Configuring the node for real proofs...`);
+      await this.aztecNode.setConfig({
+        realProofs: true,
+        minTxsPerBlock: this.minNumberOfTxsPerBlock,
+      });
+    } else {
+      this.circuitProofVerifier = new TestCircuitVerifier();
+    }
 
     this.logger.debug(`Main setup completed, initializing full prover PXE, Node, and Prover Node...`);
 
     for (let i = 0; i < 2; i++) {
       const result = await setupPXEService(
         this.aztecNode,
         {
-          proverEnabled: true,
+          proverEnabled: this.realProofs,
           bbBinaryPath: bbConfig?.bbBinaryPath,
           bbWorkingDirectory: bbConfig?.bbWorkingDirectory,
         },
@@ -239,7 +245,7 @@ export class FullProverTest {
       txProviderNodeUrl: undefined,
       dataDirectory: undefined,
       proverId: new Fr(81),
-      realProofs: true,
+      realProofs: this.realProofs,
       proverAgentConcurrency: 2,
       publisherPrivateKey: `0x${proverNodePrivateKey!.toString('hex')}`,
       proverNodeMaxPendingJobs: 100,
@@ -341,13 +347,17 @@ export class FullProverTest {
   }
 
   async deployVerifier() {
+    if (!this.realProofs) {
+      return;
+    }
+
     if (!this.circuitProofVerifier) {
       throw new Error('No verifier');
     }
 
     const { walletClient, publicClient, l1ContractAddresses } = this.context.deployL1ContractsValues;
 
-    const contract = await this.circuitProofVerifier.generateSolidityContract(
+    const contract = await (this.circuitProofVerifier as BBCircuitVerifier).generateSolidityContract(
       'BlockRootRollupArtifact',
       'UltraHonkVerifier.sol',
     );

yarn-project/end-to-end/src/e2e_prover/full.test.ts

@@ -8,7 +8,8 @@ const TIMEOUT = 1_800_000;
 process.env.AVM_PROVING_STRICT = '1';
 
 describe('full_prover', () => {
-  const t = new FullProverTest('full_prover', 2);
+  const realProofs = !['true', '1'].includes(process.env.FAKE_PROOFS ?? '');
+  const t = new FullProverTest('full_prover', 2, realProofs);
   let { provenAssets, accounts, tokenSim, logger } = t;
 
   beforeAll(async () => {
@@ -83,6 +84,11 @@ describe('full_prover', () => {
   );
 
   it('rejects txs with invalid proofs', async () => {
+    if (!realProofs) {
+      t.logger.warn(`Skipping test with fake proofs`);
+      return;
+    }
+
     const privateInteraction = t.fakeProofsAsset.methods.transfer(accounts[1].address, 1);
     const publicInteraction = t.fakeProofsAsset.methods.transfer_public(accounts[0].address, accounts[1].address, 1, 0);