Skip to content

Commit 091424b

Browse files
committed
Fix typos
1 parent 5c0932c commit 091424b

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ template <typename TestType> class stdlib_biggroup : public testing::Test {
390390
if (uint256_t(scalar).get_bit(0)) {
391391
scalar -= fr(1); // make sure to add skew
392392
}
393-
394393
element_ct P = element_ct::from_witness(&builder, input);
395394
scalar_ct x = scalar_ct::from_witness(&builder, scalar);
396395

@@ -761,7 +760,6 @@ template <typename TestType> class stdlib_biggroup : public testing::Test {
761760
OriginTag(/*parent_index=*/0, /*child_index=*/i, /*is_submitted=*/false));
762761
tag_union = OriginTag(tag_union, circuit_scalars[i].get_origin_tag());
763762
}
764-
765763
element_ct result_point =
766764
element_ct::batch_mul(circuit_points, circuit_scalars, /*max_num_bits=*/0, /*with_edgecases=*/true);
767765

@@ -855,7 +853,6 @@ template <typename TestType> class stdlib_biggroup : public testing::Test {
855853

856854
std::vector<element_ct> circuit_points;
857855
std::vector<scalar_ct> circuit_scalars;
858-
859856
OriginTag tag_union{};
860857
for (size_t i = 0; i < num_points; ++i) {
861858
circuit_points.push_back(element_ct::from_witness(&builder, points[i]));

barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ element<C, Fq, Fr, G> element<C, Fq, Fr, G>::batch_mul(const std::vector<element
764764
for (size_t i = 0; i < scalars.size(); i++) {
765765
// If batch_mul actually performs batch multiplication on the points and scalars, subprocedures can do
766766
// operations like addition or subtraction of points, which can trigger OriginTag security mechanisms even
767-
// though the final result satisfies the secureity logic
767+
// though the final result satisfies the security logic
768768
// For example result = submitted_in_round_0 *challenge_from_round_0 +submitted_in_round_1 *
769769
// challenge_in_round_1 will trigger it, because the addition of submitted_in_round_0 to submitted_in_round_1 is
770770
// dangerous by itself. To avoid this, we remove the tags, merge them separately and set the result

0 commit comments

Comments
 (0)