fix: add bytecode instances in reverse (#11064)

IlyasRidhuan · dbanks12 · web-flow · commit 036496ce7496 · 2025-01-06T16:47:07.000Z
Since we cache hints from earlier instances, when receiving hints for
instances we keep the earliest hints

Co-authored-by: David Banks &lt;47112877+dbanks12@users.noreply.github.com&gt;
diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/trace/execution_hints.hpp b/barretenberg/cpp/src/barretenberg/vm/avm/trace/execution_hints.hpp
@@ -275,7 +275,7 @@ struct ExecutionHints {
         std::vector<ContractInstanceHint> contract_instance_hints_vec;
         read(it, contract_instance_hints_vec);
         std::map<FF, ContractInstanceHint> contract_instance_hints;
-        for (const auto& instance : contract_instance_hints_vec) {
+        for (const auto& instance : std::views::reverse(contract_instance_hints_vec)) {
             contract_instance_hints[instance.address] = instance;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ struct ExecutionHints {`
`275`	`275`	`std::vector<ContractInstanceHint> contract_instance_hints_vec;`
`276`	`276`	`read(it, contract_instance_hints_vec);`
`277`	`277`	`std::map<FF, ContractInstanceHint> contract_instance_hints;`
`278`		`- for (const auto& instance : contract_instance_hints_vec) {`
	`278`	`+ for (const auto& instance : std::views::reverse(contract_instance_hints_vec)) {`
`279`	`279`	`contract_instance_hints[instance.address] = instance;`
`280`	`280`	`}`
`281`	`281`