Skip to content

Commit 1878f0e

Browse files
xwjiang-msparmarkj
authored andcommitted
Pin requests to version 2.31.0 in main.yml (sonic-net#12959)
What is the motivation for this PR? In latest requests python package, would got error in some steps like add-topo and restart-ptf with message 'Not supported URL scheme http+docker' We already have fix PR sonic-net#12910 in master branch to install stable requests version in docker.yml, but once package_installation was set to false like restart-ptf, docker.yml would skip and report error again How did you do it? Install stable requests version in main.yml after executing docker.yml to cover all scenario
1 parent 5882867 commit 1878f0e

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

ansible/roles/vm_set/tasks/docker.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,4 @@
9494
pip: name=docker version=6.1.0 state=forcereinstall executable={{ pip_executable }}
9595
become: yes
9696
environment: "{{ proxy_env | default({}) }}"
97-
# Workaround for '"Error connecting: Error while fetching server API version: Not supported URL scheme http+docker'
98-
# See https://github.com/docker/docker-py/issues/3256
99-
- name: Remove old requests package >=2.32.0
100-
pip: name=requests state=absent executable={{ pip_executable }}
101-
become: yes
102-
environment: "{{ proxy_env | default({}) }}"
103-
ignore_errors: yes
104-
- name: Install requests package <2.32.0
105-
pip: name=requests version=2.31.0 state=present executable={{ pip_executable }}
106-
become: yes
107-
environment: "{{ proxy_env | default({}) }}"
10897
when: pip_executable=="pip3"

0 commit comments

Comments
 (0)