Move DeferredSetter instance to ValueStore #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e DeferredSetter for both styled and direct properties.
…nary. Remove SettingStatus entries for bindings from the dictionary for bindings that don't create a queue of pending values.
grokys
requested changes
Jul 17, 2018
src/Avalonia.Base/AvaloniaObject.cs
Outdated
| return ((IDirectPropertyAccessor)GetRegistered(property)).GetValue(this); | ||
| } | ||
| else if (_values != null) | ||
| else if (Values != null) |
Member
There was a problem hiding this comment.
Values can never be null can it? I think this should be changed back to _values.
src/Avalonia.Base/AvaloniaObject.cs
Outdated
| VerifyAccess(); | ||
|
|
||
| return _values?.IsAnimating(property) ?? false; | ||
| return Values?.IsAnimating(property) ?? false; |
Member
There was a problem hiding this comment.
This should be _values too - we don't want to create the object here.
src/Avalonia.Base/AvaloniaObject.cs
Outdated
| VerifyAccess(); | ||
|
|
||
| return _values?.IsSet(property) ?? false; | ||
| return Values?.IsSet(property) ?? false; |
src/Avalonia.Base/AvaloniaObject.cs
Outdated
| { | ||
| VerifyAccess(); | ||
| _values?.Revalidate(property); | ||
| Values?.Revalidate(property); |
grokys
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
DeferredSetterinstance(s) to ValueStore. Now eachAvaloniaObjecthas oneDeferredSetterand there is not a global instance. Additionally, add aSingleOrQueueclass to reduce memory usage inDeferredSettermachinery.With these changes, memory usage in Control Catalog is reduced as shown below:
In #1703:
In this PR: