Use custom Rx classes #1690
Merged
Use custom Rx classes #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a custom `ClassObserver` for observing changes to a control's classes. This saves shaves off about 15% memory use in ControlCatalog after cyling through all tabs.
Can be expressed more cleanly given the new `ActivatedObject`.
And make `ActivatedObservable` inherit from it.
And use it for `ActivatedValue`.
And remove `WeakPropertyChangedObservable`/`GetWeakObservable`.
Replaced `GetObservableWithHistory` with `GetPropertyChangedObservable`.
jmacato
approved these changes
Jun 23, 2018
Collaborator
|
LGTM tested with Core2D no issues. |
Karnah
reviewed
Jun 23, 2018
| { | ||
| if (_observer != null) | ||
| { | ||
| _observer?.OnNext(value); |
This was referenced Jun 23, 2018
wieslawsoltes
requested review from
wieslawsoltes
and removed request for
wieslawsoltes
wieslawsoltes
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large proportion of our memory usage is taken up by Rx operators. The standard rx operators carry out a lot of allocations for two reasons:
This PR introduces a new
LightweightObservableBase<T>class which takes advantage of the fact that our UI is single-threaded, and is used to build custom rx classes so that we no longer need to chain standard rx operators.Memory usage
Memory usage was measured via the VS2017 diagnostic tools by running ControlCatalog in Release mode, opening all pages and then taking a memory snapshot:
master:This PR: