Signing back in: fixes issues with outdated podcast information (#1778)

Author: leandroalonso

Modules/Server/Sources/PocketCastsServer/Public/ServerSettings.swift

@@ -278,6 +278,10 @@ public class ServerSettings {
         UserDefaults.standard.removeObject(forKey: ServerConstants.UserDefaults.lastSyncTime)
     }
 
+    public class var lastSyncTime: Date? {
+        UserDefaults.standard.object(forKey: ServerConstants.UserDefaults.lastSyncTime) as? Date
+    }
+
     // Push Token
     public class func pushToken() -> String? {
         UserDefaults.standard.string(forKey: ServerConstants.UserDefaults.pushToken)

Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift

@@ -54,6 +54,11 @@ public enum FeatureFlag: String, CaseIterable {
     /// This is to fix this: https://a8c.sentry.io/share/issue/39a6d2958b674ec3b7a4d9248b4b5ffa/
     case defaultPlayerFilterCallbackFix
 
+    /// When a user sign in, we always mark ALL podcasts as unsynced
+    /// This recently caused issues, syncing changes that shouldn't have been synced
+    /// When `true`, we only mark podcasts as unsynced if the user never signed in before
+    case onlyMarkPodcastsUnsyncedForNewUsers
+
     public var enabled: Bool {
         if let overriddenValue = FeatureFlagOverrideStore().overriddenValue(for: self) {
             return overriddenValue
@@ -100,6 +105,8 @@ public enum FeatureFlag: String, CaseIterable {
             true
         case .upNextOnTabBar:
             true
+        case .onlyMarkPodcastsUnsyncedForNewUsers:
+            true
         }
     }
 

podcasts/AuthenticationHelper.swift

@@ -64,8 +64,12 @@ class AuthenticationHelper {
         ServerSettings.syncingV2Token = response.token
         ServerSettings.refreshToken = response.refreshToken
 
-        // we've signed in, set all our existing podcasts to be non synced
-        DataManager.sharedManager.markAllPodcastsUnsynced()
+        // we've signed in, set all our existing podcasts to
+        // be non synced if the user never logged in before
+        if (FeatureFlag.onlyMarkPodcastsUnsyncedForNewUsers.enabled && ServerSettings.lastSyncTime == nil)
+            || !FeatureFlag.onlyMarkPodcastsUnsyncedForNewUsers.enabled {
+            DataManager.sharedManager.markAllPodcastsUnsynced()
+        }
 
         SyncManager.syncReason = .login
         ServerSettings.clearLastSyncTime()

podcasts/DeveloperMenu.swift

@@ -37,6 +37,10 @@ struct DeveloperMenu: View {
                     }
                 }
 
+                Button("Clear all folder information") {
+                    DataManager.sharedManager.clearAllFolderInformation()
+                }
+
                 Button("Force Reload Feature Flags") {
                     FirebaseManager.refreshRemoteConfig(expirationDuration: 0) { _ in
                         (UIApplication.shared.delegate as? AppDelegate)?.updateRemoteFeatureFlags()

podcasts/SyncSigninViewController.swift

@@ -330,8 +330,12 @@ class SyncSigninViewController: PCViewController, UITextFieldDelegate {
         ServerSettings.userId = userId
         ServerSettings.saveSyncingPassword(password)
 
-        // we've signed in, set all our existing podcasts to be non synced
-        DataManager.sharedManager.markAllPodcastsUnsynced()
+        // we've signed in, set all our existing podcasts to
+        // be non synced if the user never logged in before
+        if (FeatureFlag.onlyMarkPodcastsUnsyncedForNewUsers.enabled && ServerSettings.lastSyncTime == nil)
+            || !FeatureFlag.onlyMarkPodcastsUnsyncedForNewUsers.enabled {
+            DataManager.sharedManager.markAllPodcastsUnsynced()
+        }
 
         SyncManager.syncReason = .login
         ServerSettings.clearLastSyncTime()