Skip to content

Conversation

@AKSHAT2802
Copy link
Contributor

@AKSHAT2802 AKSHAT2802 commented Apr 29, 2025

All Submissions:

Changes proposed in this Pull Request:

Closes : https://app.asana.com/1/26890605006346/project/1209882511655535/task/1209276476021330

How to test the changes in this Pull Request:

  • Add the Newspack byline block to a post or page in the WordPress editor.
  • Test the block with single and multiple authors (if Co-Authors Plus is active).
  • Adjust the avatar size from the dropdown and toggle the "Link to author archives" option in the block settings.
  • Verify that the styles are applied correctly.
  • Check the front end to ensure avatars render as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@AKSHAT2802 AKSHAT2802 marked this pull request as ready for review April 30, 2025 07:26
@AKSHAT2802 AKSHAT2802 requested a review from a team as a code owner April 30, 2025 07:26
@thomasguillot
Copy link
Contributor

Screenshot 2025-05-07 at 16 29 07@2x

We don't need to be able to edit the post authors here. Only the prefix (this should behave like Core's Author block –– No need for block alignment, but need for bold/italic/etc...)

@AKSHAT2802
Copy link
Contributor Author

Screenshot 2025-05-07 at 16 29 07@2x

We don't need to be able to edit the post authors here. Only the prefix (this should behave like Core's Author block –– No need for block alignment, but need for bold/italic/etc...)

Hii @thomasguillot

There is some confusion regarding the approach to implementation. I have followed the discussion that happened on the ticket here and implemented it to mirror the byline functionality. 🙇

Can you please guide me on the intended functionality of the block?
cc: @leogermani

@leogermani
Copy link
Contributor

Sorry @AKSHAT2802 , I think there was some miscommunication on this one. Let's get the avatar block and then we can talk about this one in a quick call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants