feat(model): add mergePlugins option to discriminator
#12613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
reviewed
Oct 31, 2022
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
A minor comment. Also we'll have to merge this into 6.8, this is a new option
lib/helpers/model/discriminator.js
Outdated
| if (applyPlugins) { | ||
| const applyPluginsToDiscriminators = get(model.base, | ||
| 'options.applyPluginsToDiscriminators', false) || !mergeHooks; | ||
| 'options.applyPluginsToDiscriminators', false) || !mergeHooks || !mergePlugins; |
Collaborator
There was a problem hiding this comment.
I'm not a fan of how mergePlugins applies here. Seems a little strange that mergePlugins also effectively disables applyPlugins.
Maybe instead we reuse applyPlugins instead of adding a new option?
lpizzinidev
force-pushed
the
feat-applyplugins
branch
from
ab5fc94 to
bdfea16
Compare
used applyPlugins option in discriminator helper instead of creating new option mergePlugins
lpizzinidev
force-pushed
the
feat-applyplugins
branch
from
bdfea16 to
1ff2654
Compare
2 tasks
This was referenced Sep 7, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12604