Revert "rust: drm: gpuvm: Add a missing lock"

jannau · jannau · commit b1de36516793 · 2026-01-03T12:24:53.000+01:00
This reverts commit 0475333. due to NULL ptr deref, see #433 Signed-off-by: Janne Grunau <j@jannau.net>
diff --git a/rust/kernel/drm/gpuvm.rs b/rust/kernel/drm/gpuvm.rs
@@ -337,9 +337,7 @@ unsafe impl<T: DriverGpuVm> AlwaysRefCounted for GpuVmBo<T> {
         unsafe {
             let resv = (*obj.as_mut().bo.obj).resv;
             bindings::dma_resv_lock(resv, core::ptr::null_mut());
-            obj.as_ref().lock_gpuva();
             bindings::drm_gpuvm_bo_put(&mut obj.as_mut().bo);
-            obj.as_ref().unlock_gpuva();
             bindings::dma_resv_unlock(resv);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -337,9 +337,7 @@ unsafe impl<T: DriverGpuVm> AlwaysRefCounted for GpuVmBo<T> {`
`337`	`337`	`unsafe {`
`338`	`338`	`let resv = (*obj.as_mut().bo.obj).resv;`
`339`	`339`	`bindings::dma_resv_lock(resv, core::ptr::null_mut());`
`340`		`- obj.as_ref().lock_gpuva();`
`341`	`340`	`bindings::drm_gpuvm_bo_put(&mut obj.as_mut().bo);`
`342`		`- obj.as_ref().unlock_gpuva();`
`343`	`341`	`bindings::dma_resv_unlock(resv);`
`344`	`342`	`}`
`345`	`343`	`}`